A QC Task to try publishing different ROOT objects#984
Merged
Conversation
I used it to look for potential leaks in TCanvas, but this Task could be useful for similar investigations in the future, even if it does not cover every popular ROOT class yet.
Barthelemy
approved these changes
Dec 7, 2021
Collaborator
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
Very useful. One missing type perhaps, for a future iteration, is TTree.
Collaborator
|
@TimoWilken Is the mac builder ok ? |
Contributor
|
The Mac builder is up, it's just been testing a queue of PRs -- this PR got unlucky; the last check for new PRs was a minute before this one was submitted. It should be picked up soon. |
Collaborator
|
@TimoWilken Thanks a lot. |
Barthelemy
pushed a commit
to Barthelemy/QualityControl
that referenced
this pull request
Jan 13, 2022
I used it to look for potential leaks in TCanvas, but this Task could be useful for similar investigations in the future, even if it does not cover every popular ROOT class yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used it to look for potential leaks in TCanvas, but this Task could be useful for similar investigations in the future, even if it does not cover every popular ROOT class yet.