Merged
Conversation
* store TGeoManager::GetPath() in MCStepLogger if track enters to restore geometry in replay. This is necessary in particular in case of steps on or in the vincinity of boundaries. Floating point precision might not be enough to find a node based on spatial coordinates. In addition, restoring from the path makes navigation and node finding obsolete during replay * extract TGEoVolume ID to VMC volume ID mapping. These are not the same for Geant4_VMC hence it is necessary. Mapping is required in replay, otheriwse, hit processing can fail. Mapping during replay is skipped if it is the identity. * make replay work for Geant4_VMC. This works thanks to above additions. * add possibility to load a custom user keepStep function from a ROOT macro * update MCReplay/README.md * additional small fixes
benedikt-voelkel
force-pushed
the
add-replay
branch
from
5f0a37f to
3a0cbd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store TGeoManager::GetPath() in MCStepLogger if track enters to
restore geometry in replay. This is necessary in particular in case of
steps on or in the vincinity of boundaries. Floating point precision
might not be enough to find a node based on spatial coordinates. In
addition, restoring from the path makes navigation and node finding
obsolete during replay
extract TGEoVolume ID to VMC volume ID mapping. These are not the same
for Geant4_VMC hence it is necessary. Mapping is required in replay,
otheriwse, hit processing can fail.
Mapping during replay is skipped if it is the identity.
make replay work for Geant4_VMC. This works thanks to above additions.
add possibility to load a custom user keepStep function from a ROOT
macro
additional small fixes