Skip to content

[OGUI-1700] Add base-app-layout for Configuration GUI#2927

Merged
graduta merged 25 commits into
devfrom
feature/CNF/OGUI-1700/base-app-layout
Aug 18, 2025
Merged

[OGUI-1700] Add base-app-layout for Configuration GUI#2927
graduta merged 25 commits into
devfrom
feature/CNF/OGUI-1700/base-app-layout

Conversation

@sKrzysieK
Copy link
Copy Markdown
Contributor

@sKrzysieK sKrzysieK commented Jun 11, 2025

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue "Status" is set to "In review"
  • PR labels are selected

@sKrzysieK sKrzysieK self-assigned this Jun 11, 2025
@sKrzysieK sKrzysieK requested a review from graduta as a code owner June 11, 2025 18:58
@sKrzysieK sKrzysieK changed the title Feature/cnf/og UI 1700/base app layout Feature/cnf/og UI 1700/base-app-layout Jun 11, 2025
Comment thread Configuration/webapp/app/components/layout/drawer/LeftDrawer.tsx Fixed
@graduta graduta changed the title Feature/cnf/og UI 1700/base-app-layout [OGUI-1700] Add base-app-layout for Configuration GUI Jun 23, 2025
@sKrzysieK sKrzysieK force-pushed the feature/CNF/OGUI-1700/base-app-layout branch from 4966d89 to 8770fae Compare June 30, 2025 21:06
@sKrzysieK sKrzysieK requested review from Deaponn and piechnikk July 8, 2025 08:52
Deaponn
Deaponn previously approved these changes Jul 20, 2025
Copy link
Copy Markdown
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we discussed on keeping test directory outside of the app directory.
Moreover, majority, if not all new components are missing documentation on their export definition.

Comment thread Configuration/package-lock.json Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed, right?

Comment thread Configuration/webapp/app/test/mocha-index.cjs
Comment thread Configuration/webapp/app/test/public/page-root-mocha.cjs Outdated
Comment thread Configuration/webapp/app/components/user-section/UserSection.tsx Outdated
Comment thread Configuration/webapp/app/components/user-section/UserSection.tsx Outdated
Comment thread Configuration/webapp/app/components/user-section/UserSection.tsx Outdated
Comment thread Configuration/webapp/app/components/layout/MainLayout.tsx
@graduta graduta merged commit 6848f02 into dev Aug 18, 2025
4 checks passed
@graduta graduta deleted the feature/CNF/OGUI-1700/base-app-layout branch August 18, 2025 15:11
@Deaponn Deaponn restored the feature/CNF/OGUI-1700/base-app-layout branch August 31, 2025 13:05
@Deaponn Deaponn deleted the feature/CNF/OGUI-1700/base-app-layout branch August 31, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants