[OGUI-1688] Update API endpoint to retrieve list of objects based on filter v2#2931
Merged
graduta merged 15 commits intoJun 18, 2025
Conversation
added 5 commits
June 14, 2025 17:59
5 tasks
mariscalromeroalejandro
suggested changes
Jun 16, 2025
Comment on lines
+134
to
+138
| async getObjectsLatestVersionList( | ||
| prefix = this._PREFIX, | ||
| filters, | ||
| fields, | ||
| ) { |
Contributor
There was a problem hiding this comment.
Consider options object:
Suggested change
| async getObjectsLatestVersionList( | |
| prefix = this._PREFIX, | |
| filters, | |
| fields, | |
| ) { | |
| async getObjectsLatestVersionList({ prefix = this._PREFIX, filters = {}, fields = [PATH, CREATED, LAST_MODIFIED] } = {}) { |
Collaborator
Author
There was a problem hiding this comment.
For only three arguments?
Contributor
There was a problem hiding this comment.
yes, filters and fields can be mixed in order by mistake
mariscalromeroalejandro
previously approved these changes
Jun 16, 2025
graduta
requested changes
Jun 18, 2025
|
|
||
| return async (req, res, next) => { | ||
| try { | ||
| req.params.id = await qcgIdDto.validateAsync(req.params?.id); |
Member
There was a problem hiding this comment.
Why is this Dto referring to qcg (which is the name of the application) instead of to the actual entity? In this case, is it an object, is it a layout?
As far as I can tell from the qcgIdDto implementation, this is a general string check that has min 1 character. Thus, it should be placed in a separate file and named accordingly
Collaborator
Author
There was a problem hiding this comment.
This is a qcObjectId (I think) (refer to QCObject.service.js::109). So, It does belong in that file, it should just be named differently.
graduta
reviewed
Jun 18, 2025
graduta
reviewed
Jun 18, 2025
NarrowsProjects
force-pushed
the
feature/QCG/OGUI-1688/add-ccdb-endpoint-that-filters-based-on-run-number-v2
branch
from
c62ca5a to
436e041
Compare
…filters-based-on-run-number-v2
graduta
approved these changes
Jun 18, 2025
graduta
deleted the
feature/QCG/OGUI-1688/add-ccdb-endpoint-that-filters-based-on-run-number-v2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
This PR alters the ObjectController::getObjects function and and corresponding ObjectService functions to accept filters as an optional parameter.
The objectService function will decide between the ccdb's tree and latest API based on the presence of the filters
It also adds middleware for the following endpoints:
/object
/object/:id
/objects