[OGUI-1690] Persist filters between pages v2#2933
Merged
graduta merged 25 commits intoJun 20, 2025
Merged
Conversation
NarrowsProjects
force-pushed
the
feature/QCG/OGUI-1690/automatically-fill-in-run-number-on-applicable-pages-v2
branch
4 times, most recently
from
2c4dbe6 to
807fa67
Compare
added 14 commits
June 19, 2025 13:26
NarrowsProjects
force-pushed
the
feature/QCG/OGUI-1690/automatically-fill-in-run-number-on-applicable-pages-v2
branch
from
807fa67 to
c145617
Compare
…OGUI-1690/automatically-fill-in-run-number-on-applicable-pages-v2
NarrowsProjects
force-pushed
the
feature/QCG/OGUI-1690/automatically-fill-in-run-number-on-applicable-pages-v2
branch
from
3bf02e9 to
de9dbaf
Compare
graduta
requested changes
Jun 19, 2025
Member
graduta
left a comment
graduta
left a comment
There was a problem hiding this comment.
I believe, the "Clear" button should also fetch the new objects
NarrowsProjects
force-pushed
the
feature/QCG/OGUI-1690/automatically-fill-in-run-number-on-applicable-pages-v2
branch
from
0d3dbf9 to
858639c
Compare
NarrowsProjects
force-pushed
the
feature/QCG/OGUI-1690/automatically-fill-in-run-number-on-applicable-pages-v2
branch
from
858639c to
73bf7ab
Compare
graduta
requested changes
Jun 20, 2025
Member
graduta
left a comment
graduta
left a comment
There was a problem hiding this comment.
I have identified a bug which is introduced by this PR. To reproduce:
- Go to a layout with objects
- Make sure you have at least an object that loads correctly
- Click on the expand icon to see the object in objectView page full screen
- At this point, you see in the URL parameters objectId and layoutID
- select a different version timestamp of the object
- objectId and layoutID were replaced by objectName. This means that also the "Back to layout" button has been replaced by "BacK"
- At this point cannot get back to the previous layout that was at
NarrowsProjects
force-pushed
the
feature/QCG/OGUI-1690/automatically-fill-in-run-number-on-applicable-pages-v2
branch
from
6ad838e to
bd21243
Compare
graduta
approved these changes
Jun 20, 2025
graduta
deleted the
feature/QCG/OGUI-1690/automatically-fill-in-run-number-on-applicable-pages-v2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
This PR depends on #2932
This PR makes the run number filter, as well as every other filter persist by adding it in the URL.
This is achieved by permanently adding the filter element to the header. And using the filter in QCObject.service and Layout.service API requests.