Skip to content

[OGUI-1698] Implement configuration endpoint#2943

Merged
graduta merged 16 commits into
devfrom
feature/CNF/OGUI-1698/implement-configuration-endpoint
Aug 28, 2025
Merged

[OGUI-1698] Implement configuration endpoint#2943
graduta merged 16 commits into
devfrom
feature/CNF/OGUI-1698/implement-configuration-endpoint

Conversation

@piechnikk
Copy link
Copy Markdown
Contributor

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue "Status" is set to "In review"
  • PR labels are selected

@piechnikk piechnikk requested review from Deaponn and sKrzysieK June 23, 2025 14:16
@piechnikk piechnikk marked this pull request as ready for review June 29, 2025 15:32
@piechnikk piechnikk requested a review from graduta as a code owner June 29, 2025 15:32
@piechnikk piechnikk self-assigned this Jun 29, 2025
Copy link
Copy Markdown
Contributor

@Deaponn Deaponn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some ideas

Comment thread Control/lib/controllers/QCConfiguration.controller.js Outdated
Comment thread Control/lib/services/QCConfiguration.service.js Outdated
Comment thread Control/lib/services/QCConfiguration.service.js Outdated
piechnikk and others added 2 commits July 1, 2025 19:48
Comment thread Control/lib/api.js Outdated
Comment thread Control/lib/api.js Outdated
Comment thread Control/lib/services/QCConfiguration.service.js Outdated
Comment thread Control/lib/services/QCConfiguration.service.js Outdated
Comment thread Control/lib/services/QCConfiguration.service.js Outdated
Comment thread Control/lib/services/QCConfiguration.service.js Outdated
Comment thread Control/lib/services/QCConfiguration.service.js Outdated
Comment thread Control/lib/controllers/QCConfiguration.controller.js Outdated
Comment thread Control/lib/controllers/QCConfiguration.controller.js Outdated
Comment thread Control/lib/services/QCConfiguration.service.js Outdated
@piechnikk piechnikk requested a review from graduta August 18, 2025 09:52
Copy link
Copy Markdown
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good progress! I added a few small comments to make sure the new features are in-line with our conventions.

Comment thread Control/lib/middleware/validateConsulServiceMiddlewareFactory.js Outdated
Comment thread Control/lib/api.js Outdated
Comment thread Control/lib/api.js Outdated
Comment thread Control/lib/api.js Outdated
Comment thread Control/test/config/testConfigForConsul.js Outdated
Comment thread Control/test/api/configuration/api-get-configuration.test.js Outdated
Comment thread Control/lib/controllers/QCConfiguration.controller.js Outdated
Comment thread Control/test/api/configuration/api-get-configurations.test.js
Comment thread Control/lib/services/QCConfiguration.service.js Outdated
Comment thread Control/lib/services/QCConfiguration.service.js Outdated
@piechnikk piechnikk requested a review from graduta August 20, 2025 21:19
@graduta graduta merged commit abc9492 into dev Aug 28, 2025
9 checks passed
@graduta graduta deleted the feature/CNF/OGUI-1698/implement-configuration-endpoint branch August 28, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants