Skip to content

[OGUI-329] Adapt frontend to kafka events#3079

Merged
mariscalromeroalejandro merged 31 commits intodevfrom
feature/QCG/OGUI-329/adapt-frontend-to-kafka-events
Sep 25, 2025
Merged

[OGUI-329] Adapt frontend to kafka events#3079
mariscalromeroalejandro merged 31 commits intodevfrom
feature/QCG/OGUI-329/adapt-frontend-to-kafka-events

Conversation

@mariscalromeroalejandro
Copy link
Copy Markdown
Contributor

@mariscalromeroalejandro mariscalromeroalejandro commented Sep 24, 2025

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

This PR adapts the frontend to use a dropdown with the ongoing runs provided by Kafka in runs mode.

graduta and others added 26 commits September 22, 2025 14:44
…b.com:AliceO2Group/WebUi into feature/QCG/OGUI-329/add-kafka-listener-inqcg
…ture/QCG/OGUI-329/adapt-frontend-to-kafka-events
…ure/QCG/OGUI-329/adapt-frontend-to-kafka-events
Copy link
Copy Markdown
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good direction, still needs a few improvements as I understand it still a draft PR but functionality wise it gets the job done.
One small bug if I may call it that:

  • no ongoing runs
  • user enters run Mode and it is displayed "No ongoing runs" which is very good
  • a run starts
  • user clicks on the dropdown and has the option to select the run that has just started
  • user clicks on it but dropdown displays empty selection (see screenshot)
  • user has to click again on it

1st click:
image

2nd click:
image

Comment thread QualityControl/lib/QCModel.js Outdated
Comment thread QualityControl/public/common/filters/model/FilterModel.js Outdated
Comment thread QualityControl/public/common/filters/model/FilterModel.js Outdated
Comment thread QualityControl/public/common/filters/filter.js
Comment thread QualityControl/test/public/features/runMode.test.js Outdated
@mariscalromeroalejandro mariscalromeroalejandro marked this pull request as ready for review September 25, 2025 09:07
@mariscalromeroalejandro mariscalromeroalejandro merged commit 2e2c251 into dev Sep 25, 2025
10 checks passed
@mariscalromeroalejandro mariscalromeroalejandro deleted the feature/QCG/OGUI-329/adapt-frontend-to-kafka-events branch September 25, 2025 11:25
Deaponn pushed a commit that referenced this pull request Oct 6, 2025
This PR adapts the frontend to use a dropdown with the ongoing runs provided by Kafka in runs mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants