More Efficient extractDomElements #70
Merged
+361
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize extractDomElements to not construct a dom. instead we simply run the parser to find the open/close tags for
headandbody, and slice the html string using the indices.this avoids allocating dom objects when reading and avoids the work of writing those dom objects back into strings afterwards
Testing
On AlignableWeb, used bombardier to make 100 request against
/sitemaproute.Took memory and cpu profiles before and after, isolating
extractDomElementsfunction.