Skip to content

Fix splash screen page indicators positioning and state#1

Merged
Alime21 merged 2 commits intomainfrom
copilot/fix-splash-screen-indicator
Nov 15, 2025
Merged

Fix splash screen page indicators positioning and state#1
Alime21 merged 2 commits intomainfrom
copilot/fix-splash-screen-indicator

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 15, 2025

Splash screen 2's TabLayout indicator was misaligned (left-constrained instead of centered) and lacked an ID. Neither splash screen indicated which page was active.

Layout changes:

  • Centered TabLayout in Splash2 by adding end constraint and removing start margin
  • Added android:id="@+id/tabLayout" to Splash2's TabLayout
  • Added explicit TabItems to both splash screens (2 tabs each)
  • Aligned nextArrow2 to TabLayout (matching Splash1 pattern)
  • Standardized bottom margins to 32dp across both screens

Activity changes:

  • Splash1Activity selects first tab on load
  • Splash2Activity selects second tab on load
// Splash1Activity.java
TabLayout tabLayout = findViewById(R.id.tabLayout);
TabLayout.Tab tab = tabLayout.getTabAt(0);  // First page
if (tab != null) tab.select();

// Splash2Activity.java  
TabLayout tabLayout = findViewById(R.id.tabLayout);
TabLayout.Tab tab = tabLayout.getTabAt(1);  // Second page
if (tab != null) tab.select();

Both screens now show centered page indicators with the active page highlighted.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/gradle-daemon-main-8.13.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/agents/gradle-instrumentation-agent-8.13.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.13 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

I want to fix splash screen indicator on the bottom of splash 2 and I'll add it to splash 1 too


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: KorkutKardes7 <148012191+KorkutKardes7@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix splash screen indicator for splash 1 and splash 2 Fix splash screen page indicators positioning and state Nov 15, 2025
Copilot AI requested a review from KorkutKardes7 November 15, 2025 13:27
Repository owner deleted a comment from Copilot AI Nov 15, 2025
Copy link
Copy Markdown
Collaborator

@KorkutKardes7 KorkutKardes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Fix the backgorund and positioning of the TabIndicator

@Alime21 Alime21 self-assigned this Nov 15, 2025
@KorkutKardes7 KorkutKardes7 marked this pull request as ready for review November 15, 2025 14:12
@Alime21 Alime21 merged commit 3be7edb into main Nov 15, 2025
1 check failed
@KorkutKardes7 KorkutKardes7 deleted the copilot/fix-splash-screen-indicator branch December 23, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants