fix(123_open): wire the offline download temp dir like the other cloud tools

The tool registered its scratch directory as a settings item under its
own key in the tool package, so the row existed but nothing could write
it: the admin UI reaches these settings through a dedicated endpoint per
tool, not through the generic settings form.

Move the key to internal/conf next to its siblings and add
POST /api/admin/setting/set_123_open, which validates that the target is
a working 123 Open storage before saving and re-initialises the tool,
mirroring set_115/set_pikpak/set_thunder/set_guangyapan.

Author: okatu-loli

internal/conf/const.go

@@ -81,6 +81,9 @@ const (
 	// guangyapan
 	GuangYaPanTempDir = "guangyapan_temp_dir"
 
+	// 123 open
+	Open123TempDir = "123_open_temp_dir"
+
 	// single
 	Token         = "token"
 	IndexProgress = "index_progress"

internal/offline_download/123_open/123_open.go

@@ -27,12 +27,10 @@ func (o *Open123) Name() string {
 	return tool.Open123ToolName
 }
 
-// Items registers the scratch directory the tool downloads into when the
-// destination is not a 123 Open storage.
+// Items registers no settings: the scratch directory is written by the
+// dedicated set_123_open endpoint, like the other cloud tools.
 func (o *Open123) Items() []model.SettingItem {
-	return []model.SettingItem{
-		{Key: tool.Open123TempDir, Value: "", Type: conf.TypeString, Group: model.OFFLINE_DOWNLOAD, Flag: model.PRIVATE},
-	}
+	return nil
 }
 
 // Run reports NotSupport so the framework drives the task through AddURL and
@@ -46,7 +44,7 @@ func (o *Open123) Init() (string, error) {
 }
 
 func (o *Open123) IsReady() bool {
-	tempDir := setting.GetStr(tool.Open123TempDir)
+	tempDir := setting.GetStr(conf.Open123TempDir)
 	if tempDir == "" {
 		return false
 	}

internal/offline_download/123_open/123_open_test.go

@@ -5,7 +5,6 @@ import (
 	"testing"
 
 	"github.com/alist-org/alist/v3/internal/errs"
-	"github.com/alist-org/alist/v3/internal/model"
 	"github.com/alist-org/alist/v3/internal/offline_download/tool"
 	pan123 "github.com/okatu-loli/go-123pan"
 )
@@ -20,18 +19,12 @@ func TestToolIsRegistered(t *testing.T) {
 	}
 }
 
-// TestItemsRegisterTempDir keeps the setting the tool needs discoverable in the
-// offline download settings group.
-func TestItemsRegisterTempDir(t *testing.T) {
-	items := (&Open123{}).Items()
-	if len(items) != 1 {
-		t.Fatalf("got %d setting items, want 1", len(items))
-	}
-	if items[0].Key != tool.Open123TempDir {
-		t.Errorf("setting key = %q, want %q", items[0].Key, tool.Open123TempDir)
-	}
-	if items[0].Group != model.OFFLINE_DOWNLOAD {
-		t.Errorf("setting group = %d, want the offline download group", items[0].Group)
+// TestItemsRegistersNothing pins the convention shared with the other cloud
+// tools: the scratch directory is written by the dedicated set_123_open
+// endpoint, not seeded as a settings item.
+func TestItemsRegistersNothing(t *testing.T) {
+	if items := (&Open123{}).Items(); len(items) != 0 {
+		t.Fatalf("got %d setting items, want none", len(items))
 	}
 }
 

internal/offline_download/tool/add.go

@@ -109,7 +109,7 @@ func AddURL(ctx context.Context, args *AddURLArgs) (task.TaskExtensionInfo, erro
 		if _, ok := storage.(*_123Open.Open123); ok {
 			tempDir = args.DstDirPath
 		} else {
-			tempBase := setting.GetStr(Open123TempDir)
+			tempBase := setting.GetStr(conf.Open123TempDir)
 			if tempBase == "" {
 				return nil, errors.New("123 Open temp dir is not set")
 			}

internal/offline_download/tool/base.go

@@ -8,11 +8,6 @@ const (
 	// Open123ToolName is the name the 123 Open offline download tool registers
 	// itself under.
 	Open123ToolName = "123 Open"
-	// Open123TempDir is the setting key holding the scratch directory the 123
-	// Open tool downloads into when the destination is another storage. It
-	// lives here rather than in internal/conf because the tool registers the
-	// setting itself, through Tool.Items.
-	Open123TempDir = "123_open_temp_dir"
 )
 
 type AddUrlArgs struct {

server/handles/offline_download.go

@@ -2,6 +2,7 @@ package handles
 
 import (
 	_115 "github.com/alist-org/alist/v3/drivers/115"
+	_123Open "github.com/alist-org/alist/v3/drivers/123_open"
 	guangyapandriver "github.com/alist-org/alist/v3/drivers/guangyapan"
 	"github.com/alist-org/alist/v3/drivers/pikpak"
 	"github.com/alist-org/alist/v3/drivers/thunder"
@@ -285,6 +286,50 @@ func SetGuangYaPan(c *gin.Context) {
 	common.SuccessResp(c, "ok")
 }
 
+type SetOpen123Req struct {
+	TempDir string `json:"temp_dir" form:"temp_dir"`
+}
+
+func SetOpen123(c *gin.Context) {
+	var req SetOpen123Req
+	if err := c.ShouldBind(&req); err != nil {
+		common.ErrorResp(c, err, 400)
+		return
+	}
+	if req.TempDir != "" {
+		storage, _, err := op.GetStorageAndActualPath(req.TempDir)
+		if err != nil {
+			common.ErrorStrResp(c, "storage does not exists", 400)
+			return
+		}
+		if storage.Config().CheckStatus && storage.GetStorage().Status != op.WORK {
+			common.ErrorStrResp(c, "storage not init: "+storage.GetStorage().Status, 400)
+			return
+		}
+		if _, ok := storage.(*_123Open.Open123); !ok {
+			common.ErrorStrResp(c, "unsupported storage driver for offline download, only 123 Open is supported", 400)
+			return
+		}
+	}
+	items := []model.SettingItem{
+		{Key: conf.Open123TempDir, Value: req.TempDir, Type: conf.TypeString, Group: model.OFFLINE_DOWNLOAD, Flag: model.PRIVATE},
+	}
+	if err := op.SaveSettingItems(items); err != nil {
+		common.ErrorResp(c, err, 500)
+		return
+	}
+	_tool, err := tool.Tools.Get(tool.Open123ToolName)
+	if err != nil {
+		common.ErrorResp(c, err, 500)
+		return
+	}
+	if _, err := _tool.Init(); err != nil {
+		common.ErrorResp(c, err, 500)
+		return
+	}
+	common.SuccessResp(c, "ok")
+}
+
 func OfflineDownloadTools(c *gin.Context) {
 	tools := tool.Tools.Names()
 	common.SuccessResp(c, tools)

server/router.go

@@ -182,6 +182,7 @@ func admin(g *gin.RouterGroup) {
 	setting.POST("/set_pikpak", handles.SetPikPak)
 	setting.POST("/set_thunder", handles.SetThunder)
 	setting.POST("/set_guangyapan", handles.SetGuangYaPan)
+	setting.POST("/set_123_open", handles.SetOpen123)
 	setting.POST("/set_frp", handles.SetFRP)
 	setting.POST("/stop_frp", handles.StopFRP)
 	setting.GET("/frp_runtime", handles.GetFRPRuntime)