fix(index): don't auto-index wrapper drivers' underlying storage (#9563)

Wrapper drivers (alias, crypt, strm, chunker) list their underlying
storage via fs.List. Each such call went through op.List, which fires
the objs-update hook that auto-builds the search index. As a result the
underlying real path was indexed in addition to the wrapper's own mount
path, so a file reached through an alias was indexed under both paths
and showed up as duplicate search results when auto index build was on.
Manual index build was unaffected because it indexes via an explicit
tree walk while the update hook is disabled.

Add a NoUpdateIndex flag to fs.ListArgs / model.ListArgs that skips the
objs-update hook in op.List, and set it on the internal listing calls of
all four wrapper drivers. The wrapper's own mount path is still indexed
via its outer op.List call, and direct access to the underlying storage
still indexes normally.

Fixes #9489

Author: okatu-loli

drivers/alias/driver.go

@@ -92,7 +92,7 @@ func (d *Alias) List(ctx context.Context, dir model.Obj, args model.ListArgs) ([
 		return nil, errs.ObjectNotFound
 	}
 	var objs []model.Obj
-	fsArgs := &fs.ListArgs{NoLog: true, Refresh: args.Refresh}
+	fsArgs := &fs.ListArgs{NoLog: true, Refresh: args.Refresh, NoUpdateIndex: true}
 	for _, dst := range dsts {
 		tmp, err := d.list(ctx, dst, sub, fsArgs)
 		if err == nil {

drivers/chunker/util.go

@@ -900,5 +900,5 @@ func (d *Chunker) openPartRange(ctx context.Context, link *model.Link, size, off
 }
 
 func fsList(ctx context.Context, remotePath string, refresh bool) ([]model.Obj, error) {
-	return fs.List(ctx, remotePath, &fs.ListArgs{NoLog: true, Refresh: refresh})
+	return fs.List(ctx, remotePath, &fs.ListArgs{NoLog: true, Refresh: refresh, NoUpdateIndex: true})
 }

drivers/crypt/driver.go

@@ -110,7 +110,7 @@ func (d *Crypt) List(ctx context.Context, dir model.Obj, args model.ListArgs) ([
 	//return d.list(ctx, d.RemotePath, path)
 	//remoteFull
 
-	objs, err := fs.List(ctx, d.getPathForRemote(path, true), &fs.ListArgs{NoLog: true})
+	objs, err := fs.List(ctx, d.getPathForRemote(path, true), &fs.ListArgs{NoLog: true, NoUpdateIndex: true})
 	// the obj must implement the model.SetPath interface
 	// return objs, err
 	if err != nil {

drivers/strm/driver.go

@@ -143,7 +143,7 @@ func (d *Strm) List(ctx context.Context, dir model.Obj, args model.ListArgs) ([]
 	out := make([]model.Obj, 0)
 	for _, targetRoot := range targets {
 		realDir := stdpath.Join(targetRoot, sub)
-		objs, err := fs.List(ctx, realDir, &fs.ListArgs{NoLog: true, Refresh: args.Refresh})
+		objs, err := fs.List(ctx, realDir, &fs.ListArgs{NoLog: true, Refresh: args.Refresh, NoUpdateIndex: true})
 		if err != nil {
 			continue
 		}
@@ -188,7 +188,7 @@ func (d *Strm) rotateAllLocal(ctx context.Context) {
 }
 
 func (d *Strm) walkAndSync(ctx context.Context, virtualDir, realDir string) {
-	objs, err := fs.List(ctx, realDir, &fs.ListArgs{NoLog: true, Refresh: true})
+	objs, err := fs.List(ctx, realDir, &fs.ListArgs{NoLog: true, Refresh: true, NoUpdateIndex: true})
 	if err != nil {
 		log.Warnf("strm: rotate list failed %s: %v", realDir, err)
 		return

internal/fs/fs.go

@@ -20,6 +20,10 @@ import (
 type ListArgs struct {
 	Refresh bool
 	NoLog   bool
+	// NoUpdateIndex skips the auto search-index update hook for this listing.
+	// Wrapper drivers set it when listing their underlying storage so the real
+	// path is not auto-indexed alongside the wrapper's mount path.
+	NoUpdateIndex bool
 }
 
 func List(ctx context.Context, path string, args *ListArgs) ([]model.Obj, error) {

internal/fs/list.go

@@ -24,8 +24,9 @@ func list(ctx context.Context, path string, args *ListArgs) ([]model.Obj, error)
 	var _objs []model.Obj
 	if storage != nil {
 		_objs, err = op.List(ctx, storage, actualPath, model.ListArgs{
-			ReqPath: path,
-			Refresh: args.Refresh,
+			ReqPath:       path,
+			Refresh:       args.Refresh,
+			NoUpdateIndex: args.NoUpdateIndex,
 		})
 		if err != nil {
 			if !args.NoLog {

internal/model/args.go

@@ -14,6 +14,12 @@ type ListArgs struct {
 	ReqPath           string
 	S3ShowPlaceholder bool
 	Refresh           bool
+	// NoUpdateIndex skips the objs-update hook (used to auto-build the search
+	// index) for this listing. Wrapper drivers (alias, crypt, strm, chunker)
+	// set it when listing their underlying storage so the real path is not
+	// auto-indexed alongside the wrapper's own mount path, which would create
+	// duplicate search entries.
+	NoUpdateIndex bool
 }
 
 type LinkArgs struct {

internal/op/fs.go

@@ -143,9 +143,11 @@ func List(ctx context.Context, storage driver.Driver, path string, args model.Li
 		// warp obj name
 		model.WrapObjsName(files)
 		// call hooks
-		go func(reqPath string, files []model.Obj) {
-			HandleObjsUpdateHook(reqPath, files)
-		}(utils.GetFullPath(storage.GetStorage().MountPath, path), files)
+		if !args.NoUpdateIndex {
+			go func(reqPath string, files []model.Obj) {
+				HandleObjsUpdateHook(reqPath, files)
+			}(utils.GetFullPath(storage.GetStorage().MountPath, path), files)
+		}
 
 		// sort objs
 		if storage.Config().LocalSort {