Skip to content

enhance wehbook logic for terway-controlplane#545

Merged
BSWANG merged 3 commits intoAliyunContainerService:mainfrom
l1b0k:main
Dec 6, 2023
Merged

enhance wehbook logic for terway-controlplane#545
BSWANG merged 3 commits intoAliyunContainerService:mainfrom
l1b0k:main

Conversation

@l1b0k
Copy link
Copy Markdown
Collaborator

@l1b0k l1b0k commented Dec 4, 2023

No description provided.

@l1b0k l1b0k requested a review from BSWANG December 4, 2023 12:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (752d7ab) 17.51% compared to head (4b998fa) 17.42%.

Files Patch % Lines
pkg/controller/webhook/mutating.go 0.00% 7 Missing ⚠️
pkg/controller/webhook/validate.go 0.00% 6 Missing ⚠️
pkg/utils/k8s.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
- Coverage   17.51%   17.42%   -0.10%     
==========================================
  Files         105      105              
  Lines       13854    13864      +10     
==========================================
- Hits         2427     2416      -11     
- Misses      11112    11132      +20     
- Partials      315      316       +1     
Flag Coverage Δ
unittests 17.42% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread pkg/utils/k8s.go Outdated
@l1b0k l1b0k requested a review from BSWANG December 5, 2023 06:35
@BSWANG BSWANG merged commit 6aeadef into AliyunContainerService:main Dec 6, 2023
cursor Bot pushed a commit that referenced this pull request Sep 7, 2025
enhance wehbook logic for terway-controlplane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants