Skip to content

support erdma#554

Merged
l1b0k merged 1 commit intoAliyunContainerService:mainfrom
BSWANG:main
Jan 22, 2024
Merged

support erdma#554
l1b0k merged 1 commit intoAliyunContainerService:mainfrom
BSWANG:main

Conversation

@BSWANG
Copy link
Copy Markdown
Member

@BSWANG BSWANG commented Jan 18, 2024

No description provided.

@BSWANG BSWANG force-pushed the main branch 2 times, most recently from 6109817 to 2e2b1fe Compare January 18, 2024 13:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 18, 2024

Codecov Report

Attention: 208 lines in your changes are missing coverage. Please review.

Comparison is base (3a329ef) 18.41% compared to head (759f34c) 18.16%.

Files Patch % Lines
daemon/daemon.go 0.00% 81 Missing ⚠️
deviceplugin/eni.go 0.00% 45 Missing ⚠️
pkg/aliyun/client/types.go 0.00% 16 Missing ⚠️
pkg/utils/rdma_linux.go 0.00% 16 Missing ⚠️
pkg/factory/aliyun/aliyun.go 0.00% 15 Missing ⚠️
pkg/k8s/k8s.go 0.00% 8 Missing ⚠️
pkg/aliyun/instance/instance.go 0.00% 7 Missing ⚠️
daemon/config.go 14.28% 4 Missing and 2 partials ⚠️
pkg/aliyun/client/ecs.go 0.00% 4 Missing ⚠️
pkg/eni/local.go 20.00% 4 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   18.41%   18.16%   -0.25%     
==========================================
  Files         106      107       +1     
  Lines       12248    12420     +172     
==========================================
+ Hits         2255     2256       +1     
- Misses       9681     9849     +168     
- Partials      312      315       +3     
Flag Coverage Δ
unittests 18.16% <2.80%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG force-pushed the main branch 3 times, most recently from cbdc75b to 8536449 Compare January 22, 2024 01:45
Comment thread pkg/eni/erdma.go Outdated
Comment thread plugin/driver/types/types.go Outdated
Signed-off-by: bingshen.wbs <bingshen.wbs@alibaba-inc.com>
Comment thread pkg/utils/rdma_linux.go
@l1b0k l1b0k merged commit 301c557 into AliyunContainerService:main Jan 22, 2024
cursor Bot pushed a commit that referenced this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants