Skip to content

Remove sys_admin capability requirment on erdma support checking#561

Merged
l1b0k merged 1 commit intoAliyunContainerService:mainfrom
BSWANG:main
Jan 24, 2024
Merged

Remove sys_admin capability requirment on erdma support checking#561
l1b0k merged 1 commit intoAliyunContainerService:mainfrom
BSWANG:main

Conversation

@BSWANG
Copy link
Copy Markdown
Member

@BSWANG BSWANG commented Jan 22, 2024

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (74ed965) 18.13% compared to head (c4b7fb0) 18.17%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/utils/node_capabilities.go 26.31% 14 Missing ⚠️
daemon/daemon.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   18.13%   18.17%   +0.04%     
==========================================
  Files         107      107              
  Lines       12438    12438              
==========================================
+ Hits         2256     2261       +5     
+ Misses       9867     9862       -5     
  Partials      315      315              
Flag Coverage Δ
unittests 18.17% <23.80%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: bingshen.wbs <bingshen.wbs@alibaba-inc.com>
@l1b0k l1b0k merged commit 864f074 into AliyunContainerService:main Jan 24, 2024
cursor Bot pushed a commit that referenced this pull request Sep 7, 2025
Remove sys_admin capability requirment on erdma support checking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants