[pull] main from sourcegraph:main#45
Merged
pull[bot] merged 8 commits intoAll-Blockchains:mainfrom Jun 19, 2021
Merged
Conversation
… automatically with all events (#22198)
…nd log click event (#22239) - Rename settings button from "Add search scope" to "Add search snippet". From https://github.com/sourcegraph/sourcegraph/pull/22091#discussion_r654557408 - Update schema description of `search.scopes` to read "Predefined search snippets that can be appended to any search (also known as search scopes)". The setting is still called `search.scopes` for backwards compatibility. - Log event `SearchSnippetClicked` when a snippet is clicked in the sidebar. This event will not have a filter value for privacy reasons, since snippets are user-defined. Closes #21682
This removes feature flag guards for sending repo metadata with our streaming search results. These features have been enabled for a day now with no performance degradation, so I think it's safe to remove them from the code so they are enabled by default on customer instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )