[pull] master from web-platform-tests:master #1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature: `min-max-content` Feature: `min-max-width-height` Reference: https://github.com/web-platform-dx/web-features/blob/main/features/min-max-content.yml Reference: https://github.com/web-platform-dx/web-features/blob/main/features/min-max-width-height.yml Notable exclusions 1. Fieldset implementation details - `html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-calculating-min-max-content.html` 2. Flexbox-specific layout behavior - `css/css-flexbox/flexbox-min-width-auto-*.html` - `css/css-flexbox/flexbox-min-height-auto-*.html` Co-authored-by: Chris Cuellar <58723+ChrisC@users.noreply.github.com>
Feature: `outlines` Reference: https://github.com/web-platform-dx/web-features/blob/main/features/outlines.yml Differentiation logic: The `outlines` feature covers the longhand properties (`outline-width`, `outline-style`, `outline-color`, `outline-offset`). The `outline` feature covers the shorthand property. To prevent overlap, I remapped some of the the `outline` feature mapping to explicitly exclude the longhand patterns (e.g., `!outline-width-*`). Co-authored-by: Chris Cuellar <58723+ChrisC@users.noreply.github.com>
Feature: `canvas`, `canvas-2d` Reference: - https://github.com/web-platform-dx/web-features/blob/main/features/canvas.yml - https://github.com/web-platform-dx/web-features/blob/main/features/canvas-2d.yml This PR is quite large because `html/canvas/element` couldn't be mapped recursively to `canvas-2d` due to two of the subdirectories mapping to `canvas` Unclassifiable features attempted to map during this process: `canvas-2d-desynchronized`, `canvas-2d-willreadfrequently`, `canvas-context-lost` Notable exclusions: 1. `offscreen-canvas` tests: Excluded from `canvas` and `canvas-2d` mapping as they belong to `offscreen-canvas` feature. - `html/canvas/offscreen/` 2. `canvas-2d-desynchronized` and `canvas-2d-willreadfrequently`: No exclusive tests found. - Tests for these features (`getContextAttributes.html`, `2d.getContext.options.any.js`) also test other `canvas-2d` attributes and are mapped to `canvas-2d` (or `offscreen-canvas` via existing mappings) to avoid overlapping feature definitions. - `offscreencanvas.transfer.lowlatency.nocrash.html` is mapped to `offscreen-canvas` and not remapped to `canvas-2d-desynchronized` to avoid overlap. 3. `canvas-context-lost`: No specific tests found in WPT `html/canvas` (only WebGL/WebXR related `webglcontextlost` which are excluded). 4. `css/` tests: Many CSS tests use canvas as a replaced element to test CSS properties (e.g. `mix-blend-mode`, `object-fit`), but are not testing canvas baseline support itself. - `css/compositing/mix-blend-mode/mix-blend-mode-canvas-parent.html` - `css/css-images/object-fit-contain-png-001c.html` Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Differential Revision: https://phabricator.services.mozilla.com/D280086 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2011729 gecko-commit: 8c65d484909e2fe53f69c31e87674929325cf984 gecko-reviewers: emilio, layout-reviewers
Feature: `matchmedia` Reference: https://github.com/web-platform-dx/web-features/blob/main/features/matchmedia.yml Notable exclusions 1. `css/mediaqueries/*` - Most tests in this directory test specific media features (e.g., `prefers-color-scheme`, `display-mode`) using `matchMedia` or `@media`. They are excluded because they test the specific feature, not the `matchMedia` API itself. - `css/mediaqueries/display-mode.html` - `css/mediaqueries/prefers-color-scheme.html` - `css/mediaqueries/scripting.html` - `css/mediaqueries/update-media-feature.html` 2. `device-posture/*` - Tests device posture media queries, not the API mechanism. 3. `viewport-segments/*` - Tests viewport segments media queries. Co-authored-by: Philip Jägenstedt <philip@foolip.org>
…`text-orientation`, and `text-justify` (#56570)
Enable autoplay for video in the language model prompt.
The bug 476742109 describes a case where the conic-gradient value gets an incorrect <position> because the "lh" units are computed with the wrong values. The root cause of the incorrect position comes from the fact that the ResolveGradientValue method is called before the UpdateLineHeight method by the StyleResolverState instance. This situation happens because the mask-image CSS property is defined as high-priority, hence applied before the line-height is computed. This CL solves the issue by removing the mask-image from the high-priority list. However, the mask-image property must be applied before the mask-composite, hence we need to reduce its priority using a negative value in this case. Bug: 476742109 Change-Id: If1130dd6aacfb7d86faac040b071856f2f355371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7508374 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/main@{#1573626}
Though still pending CSSWG resolution, this is our latest recommendation for handling of of name discovery in a subtree. Bug: 476025617 Change-Id: I7ef4e97ce5801dc78ac7a5ebb63d07606c3bb6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7493821 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1573754}
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/vXtAmrVZeDk Change-Id: I3d54bb17743517a8e34078ef28dacc2774037380 Bug: 454354290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7410045 Commit-Queue: Barry Pollard <barrypollard@chromium.org> Reviewed-by: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Reviewed-by: Michal Mocny <mmocny@chromium.org> Cr-Commit-Position: refs/heads/main@{#1573800}
Unconditional requests for 'shader-f16' caused requestDevice() to throw a TypeError on unsupported hardware, aborting the entire test suite. This CL only requires the feature if the adapter supports it and ensures 'float32' tests can run even if 'float16' cannot. Bug: 345352987 Change-Id: I696d6375c0c17459f8c6d6afc21971865105ae72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7510471 Reviewed-by: Phillis Tang <phillis@chromium.org> Commit-Queue: Bernhart, Bryan <bryan.bernhart@intel.com> Cr-Commit-Position: refs/heads/main@{#1573826}
OffscreenCanvas has no associated DOM element context, but CSSMathExpressionSiblingFunction::ComputeDouble
attempts to access the element pointer (via length_resolver.GetElement()) when resolving
sibling-index() in font-size calculations (e.g. `calc(10px * sibling-index())`). This leads to
a null pointer dereference and crash.
Fix by adding a null check for the element pointer in ComputeDouble:
- If the element is null (OffscreenCanvas or other DOM-less contexts), return 0 as a safe default
- Prevents invalid access to element->GetTreeScope()/ownerDocument() when no DOM element exists
Test case:
<!DOCTYPE html>
<script>
const offscreenCanvas = new OffscreenCanvas(300, 300);
const ctx = offscreenCanvas.getContext("2d");
ctx.font = "calc(10px * sibling-index()) serif"; // No longer crashes
</script>
Bug: 469455174
Change-Id: I6640ff6c25e1ac830e34ffaf7def51c6252da4ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7366009
Commit-Queue: Hewro Hewei <ihewro@chromium.org>
Reviewed-by: Hewro Hewei <ihewro@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1573468}
Differential Revision: https://phabricator.services.mozilla.com/D279723 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1994346 gecko-commit: 7b4f7e730aa617456c9d00d8ace75073b78f9666 gecko-reviewers: dholbert
…r causing WR failures This reverts commit 2cead8c0d6bdad6bb45e780156aa74a25aa2820b. Revert "Bug 1994346 - Adjust existing test expectations. r=layout-reviewers,dshin,dholbert" This reverts commit 527178ed44ad9508a88e7fee74b02022021d5ad8. Revert "Bug 1994346 - Push abspos first-in-flow to next absCB continuation if it doesn't fit. r=layout-reviewers,dholbert,dshin" This reverts commit 8ccca3d28a35fe162f46d302168a44ed989e47c8. gecko-commit: 692cc4d43d0b5b4fcadd1a780f00c7323250f572 gecko-reviewers: dholbert
Differential Revision: https://phabricator.services.mozilla.com/D279723 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1994346 gecko-commit: 08b89abace50791184a909e0d4b115abee67514d gecko-reviewers: dholbert
This broke in bug 1362499 because we turned that into a shorthand. Differential Revision: https://phabricator.services.mozilla.com/D279884 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2010526 gecko-commit: cc1c21fbd73508cca219f92b9b29ae3bec1aefe4 gecko-reviewers: dholbert
…tml (#57318) This helps avoid the need to do layout/painting at fractional pixel-positions, and it aligns with the recommendation "A minimum computed font-size of 20px is suggested" from https://web-platform-tests.org/writing-tests/ahem.html#usage This patch also removes the test's fuzzy allowance, since it should no longer be needed after this change. Fixes web-platform-tests/interop#1248
…menu. This makes submenu relationships be established only by the toggle-menu command, and not also by the show-menu and hide-menu commands as before. This is because submenu relationships create builtin behaviors that both show and hide menus, so establishing them for show-menu and hide-menu commands either doesn't fully make sense or requires a bunch of complex behavior that nobody actually wants (for example, having submenus that open-on-hover but then stay open). Bug: 406566432 Change-Id: I9e467afa88eaf1ebacf37c83f2dc4bcf79c8d337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7514148 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1574094}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )