Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 30, 2025

Addressed code review feedback regarding inconsistent spacing in app/Services/ComputerScienceResourceService.php.

Changes

  • Fixed double space after equals sign in $hot_resources_query assignment (line 49)
  • Normalized to single space for consistency with codebase conventions
// Before
$hot_resources_query =  ComputerScienceResource::query()->with([...]);

// After  
$hot_resources_query = ComputerScienceResource::query()->with([...]);

The fix was applied in commit 2b5c986.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Dec 30, 2025
Copilot AI changed the title [WIP] Update to address feedback on News temp trending PR Fix spacing in ComputerScienceResourceService variable assignment Dec 30, 2025
Copilot AI requested a review from AllanKoder December 30, 2025 23:22
@AllanKoder AllanKoder marked this pull request as ready for review December 30, 2025 23:48
@AllanKoder AllanKoder merged commit 4406260 into news-temp-trending Dec 30, 2025
2 checks passed
@AllanKoder AllanKoder deleted the copilot/sub-pr-60-another-one branch December 30, 2025 23:48
AllanKoder added a commit that referenced this pull request Dec 30, 2025
* Resource Edits, and Errors Flash (#59)

* changes

* Apply automatic changes

* Update app/Http/Controllers/ResourceEditsController.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply automatic changes

* Update resources/js/Components/NewsItem.vue

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update resources/js/Components/NewsItem.vue

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Initial plan (#62)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* Initial plan (#63)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* Rename NewsItem component to TrendingResourceItem (#61)

* Initial plan

* Rename NewsItem.vue to TrendingResourceItem.vue and update all references

Co-authored-by: AllanKoder <74692833+AllanKoder@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: AllanKoder <74692833+AllanKoder@users.noreply.github.com>

* Quick npm update

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants