add pointer and click handler to order column cells #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cell-catalog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds pointer cursor styling and click handlers to order column cells in table components, allowing users to click anywhere within the cell to open order links.
- Added CSS styling for action column cells with pointer cursor
- Implemented onCell click handlers that open order links in new tabs
- Enhanced user experience by making entire table cells clickable instead of just anchor elements
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/style/table.module.css | Added cursor pointer styling for action columns and disabled state handling |
| src/components/CellLineTable/SharedColumns.tsx | Added onCell click handler to obtainLineColumn for opening order links |
| src/components/CellLineTable/NormalTableColumns.tsx | Added onCell click handler to obtainPlasmidColumn for opening order links |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+89
to
+91
| .container .action-column:has(.action-button.disabled) { | ||
| cursor: not-allowed; | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
99
to
103
| onClick: () => { | ||
| if (record.orderLink) { | ||
| window.open(record.orderLink, "_blank", "noopener,noreferrer"); | ||
| } | ||
| }, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
51
to
57
| onCell: (record: UnpackedNormalCellLine) => ({ | ||
| onClick: () => { | ||
| if (record.orderPlasmid) { | ||
| window.open(record.orderPlasmid, "_blank", "noopener,noreferrer"); | ||
| } | ||
| }, | ||
| }), |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
interim17
changed the title
meganrm
approved these changes
Oct 13, 2025
rugeli
approved these changes
Oct 15, 2025
…talog into fix/order-click-target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #329
Solution
Added a little CSS and and
onCellproperty for the table cells.It feels like by having the
onCellwe could potentially do away with the anchor tag approach but leaving it in felt like it was more in line with accessibility standards, and we would have to rewrite more of the CSS if we took it out.