Make Edited Recipe Result File Names Unique #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rugeli
approved these changes
Jul 24, 2025
Contributor
rugeli
left a comment
rugeli
left a comment
There was a problem hiding this comment.
Tested and working! Found the unique url in job_status collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a bug where edited recipes will produce result files that will overwrite each other in s3 unless the "name" field is edited.
Link to story or ticket
Solution
Set "name" to the unique generated recipe ID for edited recipes. This name will be used in creating the result .simularium file name when the packing runs, so thus the result file name will be unique as well!