You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @AllenDang@gucio321 I saw #517 and since I've been using generics a lot recently, I figured I'd try my hand at making the changes.
The GetState and SetState functions still exist on the context struct for backwards compatibility, but there are now generic versions of them.
I've also updated the "internal" code to use the generic version instead.
I've kept the assert still for GetState to catch/prevent any mixing up of types.
The "reason" behind [T any, genericDisposable[T]] is explained here
Although I'm using it to directly call Dispose, it helps enforce the Disposable interface and it's also needed to have the return type as a pointer of the generic type.
Also to explain a bit why adding the generic type directly to func (c *context) GetState[T Disposable] doesn't work.
It's because the type parameter needs to be defined directly on the struct in order for it to be available for use in a function tied to a struct, where something like this would "work" func (c *context[T Disposable]) GetState.
But in the usecase of context, it can't be tied directly to a type since it can hold many different states, this is why I opted to make it a generic function where you pass in the context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @AllenDang @gucio321 I saw #517 and since I've been using generics a lot recently, I figured I'd try my hand at making the changes.
The
GetStateandSetStatefunctions still exist on thecontextstruct for backwards compatibility, but there are now generic versions of them.I've also updated the "internal" code to use the generic version instead.
I've kept the assert still for
GetStateto catch/prevent any mixing up of types.The "reason" behind
[T any, genericDisposable[T]]is explained hereAlthough I'm using it to directly call
Dispose, it helps enforce the Disposable interface and it's also needed to have the return type as a pointer of the generic type.Feel free to make any changes that you see fit.