Update pynwb and hdmf minimum required version #1626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djkapner
previously approved these changes
Jun 16, 2020
Contributor
djkapner
left a comment
djkapner
left a comment
There was a problem hiding this comment.
I confirmed this fixes the reported error.
njmei
dismissed stale reviews from djkapner and pickles-bread-and-butter
via
ccac5b9
njmei
force-pushed
the
1620-patch-requirements
branch
from
4de4b20 to
ccac5b9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1626 +/- ##
=======================================
Coverage 35.58% 35.58%
=======================================
Files 344 344
Lines 33568 33568
=======================================
Hits 11946 11946
Misses 21622 21622 Continue to review full report at Codecov.
|
Contributor
Author
|
@isaak-willett Sorry, forgot to bump the version could you re-approve? |
pickles-bread-and-butter
approved these changes
Jun 16, 2020
Contributor
pickles-bread-and-butter
left a comment
pickles-bread-and-butter
left a comment
There was a problem hiding this comment.
Good catch on the version bumping!
djkapner
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Some users are encountering errors using AllenSDK 2.0 because it allows for outdated versions of hdmf and pynwb dependencies.
Addresses:
Relates to: #1620
Solution:
Increase the minimum required version for hdmf and pynwb.