Skip to content

WriteNWB Needs to be used by non-mesoscope data #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Matyasz merged 1 commit into from
Oct 13, 2020
Merged

WriteNWB Needs to be used by non-mesoscope data #1749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Change Log
All notable changes to this project will be documented in this file.

## [2.3.1] = 2020-10-13

### Bug Fixes
- (Internal) Fixed a write_nwb bug for behavior ophys experiments involving the BehaviorOphysJsonApi expecting a mesoscope-specific method.

## [2.3.0] = 2020-10-09

### Added
Expand Down
2 changes: 1 addition & 1 deletion allensdk/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@



__version__ = '2.3.0'
__version__ = '2.3.1'


try:
Expand Down
11 changes: 9 additions & 2 deletions allensdk/brain_observatory/behavior/write_nwb/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@


class BehaviorOphysJsonApi(BehaviorOphysLimsApi):
"""
This class is used by both Scientifica and Mesoscope ophys experiments.
"""

def __init__(self, data):
self.data = data
Expand Down Expand Up @@ -96,7 +99,12 @@ def get_external_specimen_name(self):
return self.data['external_specimen_name']

def get_imaging_plane_group(self):
return self.data["imaging_plane_group"]
try:
# Will only contain the "imaging_plane_group" key if we are
# dealing with Mesoscope data
return self.data["imaging_plane_group"]
except KeyError:
return None


def write_behavior_ophys_nwb(session_data, nwb_filepath):
Expand All @@ -120,7 +128,6 @@ def write_behavior_ophys_nwb(session_data, nwb_filepath):
raise e



def main():

logging.basicConfig(format='%(asctime)s - %(process)s - %(levelname)s - %(message)s')
Expand Down
6 changes: 6 additions & 0 deletions doc_template/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ The Allen SDK provides Python code for accessing experimental metadata along wit
See the `mouse connectivity section <connectivity.html>`_ for more details.


What's New - 2.3.1 (October 13, 2020)
-----------------------------------------------------------------------
As of the 2.3.1 release:

- (Internal) Fixed a write_nwb bug for behavior ophys experiments involving the BehaviorOphysJsonApi expecting a mesoscope-specific method.

What's New - 2.3.0 (October 9, 2020)
-----------------------------------------------------------------------
As of the 2.3.0 release:
Expand Down