Skip to content

Conversation

@djkapner
Copy link
Contributor

@djkapner djkapner commented Oct 15, 2020

Overview:

Updating to the latest argschema release, out since January 2020.

Changes:

  • pins to latest argschema release.
  • eliminates redundant marshmallow specification.

Validation:

  • Github CIs pass
  • AllenSDK Anaconda (Github) passes (manual run)
  • AllenSDK Anaconda Nightly (Github) passes (manual run)

Checklist

  • My code follows
    Allen Institute Contribution Guidelines
  • My code is unit tested and does not decrease test coverage
  • I have performed a self review of my own code
  • My code is well-documented, and the docstrings conform to
    Numpy Standards
  • I have updated the documentation of the repository where
    appropriate
  • The header on my commit includes the issue number
  • My Pull Request has the latest AllenSDK release candidate branch
    rc/x.y.z as its merge target
  • My code passes all AllenSDK tests

Notes:

@djkapner djkapner marked this pull request as draft October 15, 2020 17:17
@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #1754 into rc/2.4.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           rc/2.4.0    #1754   +/-   ##
=========================================
  Coverage     36.16%   36.16%           
=========================================
  Files           346      346           
  Lines         33817    33817           
=========================================
  Hits          12229    12229           
  Misses        21588    21588           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21197b9...c747440. Read the comment docs.

@djkapner djkapner changed the title Update argschema GH #1756 Update argschema Oct 15, 2020
@djkapner djkapner changed the title GH #1756 Update argschema GH #1756 - Update argschema Oct 15, 2020
@djkapner djkapner marked this pull request as ready for review October 15, 2020 22:51
@djkapner djkapner requested review from kschelonka and njmei October 16, 2020 18:49
@kschelonka
Copy link
Contributor

kschelonka commented Oct 16, 2020

Did you happen to run any of the bamboo tests on prem? That's what I'm mostly concerned about

@djkapner
Copy link
Contributor Author

Did you happen to run any of the bamboo tests on prem? That's what I'm mostly concerned about

yes, see the links listed under Validation

@kschelonka
Copy link
Contributor

Oh awesome, glazed over that. My b. thanks!

@djkapner djkapner merged commit c3f7e83 into rc/2.4.0 Oct 16, 2020
@djkapner djkapner deleted the update_argschema branch February 19, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants