Skip to content

Conversation

@nicain
Copy link
Contributor

@nicain nicain commented Apr 23, 2019

This will be the last pull request merged for the 0.16.3 release

While preparing a release:

  • Create a Release Epic on ZenHub that will track the release issues and pull requests
  • Create a "release candidate" branch, and push to main fork (https://github.com/AllenInstitute/AllenSDK)
  • Create a draft pull request for the release (i.e. Release Candidate 0.16.2)
    • Assign this draft PR to the Release Epic
    • Assign a developer to be responsible for the release deployment
    • Add the Project Owner as a reviewer
    • Copy this checklist into the draft pull request description

After each major change to master:

When you are ready to release:

  • Prepare the official release commit
    • Bump version by updating version in init.py
    • Add the release date to the CHANGELOG.md and index.rst files
    • Change the draft to pull request to "ready for review"
    • Code Review with the Project Owner
    • Merge when it is ready; this will generate a merge commit, and this commit will be the official release commit.
  • Confirm that this official release commit passes all continuous integration:
  • Create a Release: https://github.com/AllenInstitute/AllenSDK/releases <"Draft a new release" button>
    • Create a draft release
    • Review the release with the Project Owner
    • Publish the release

Publish:

@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #589 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage   44.92%   44.93%   +0.01%     
==========================================
  Files          92       92              
  Lines       11885    11880       -5     
==========================================
- Hits         5339     5338       -1     
+ Misses       6546     6542       -4
Impacted Files Coverage Δ
allensdk/config/manifest.py 67.97% <0%> (-0.66%) ⬇️
allensdk/core/brain_observatory_nwb_data_set.py 22.56% <0%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc1ea9a...8fd8402. Read the comment docs.

@nicain nicain force-pushed the rc/0.16.3 branch 2 times, most recently from 8038e43 to dda3d5c Compare May 20, 2019 19:38
@nicain nicain mentioned this pull request May 22, 2019
@nicain nicain marked this pull request as ready for review May 22, 2019 22:00
Copy link
Contributor

@wbwakeman wbwakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nicain
Copy link
Contributor Author

nicain commented May 22, 2019

@NileGraddis I havent merged this PR (the resulting merge commit will be the release commit) because I have been waiting for a branch build to finish: http://bamboo.corp.alleninstitute.org/browse/IFR-AAG18-1

When this branch build is G2G, can you take over and cut the release?

@NileGraddis NileGraddis merged commit b4820d7 into master May 23, 2019
@nicain nicain deleted the rc/0.16.3 branch May 29, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants