Skip to content

Conversation

@nicain
Copy link
Contributor

@nicain nicain commented Apr 23, 2019

Internal build failing because:

  • of a version conflict with pytest and pytest-xdist. This PR will remain open until the internal builds are running again, so that the 0.16.2 whl can be published to pypi
  • Running pandas 0.24 has error behavior because of .ix notation

@nicain nicain self-assigned this Apr 23, 2019
@nicain nicain changed the title WIP update requirements.txt to resolve pytest-xdist conflict WIP update test_requirements.txt to resolve pytest-xdist conflict Apr 23, 2019
@nicain nicain added this to the 19-04-24 milestone Apr 23, 2019
@nicain nicain changed the title WIP update test_requirements.txt to resolve pytest-xdist conflict Update test_requirements.txt to resolve pytest-xdist conflict Apr 23, 2019
@nicain nicain changed the title Update test_requirements.txt to resolve pytest-xdist conflict Update test_requirements.txt to resolve pytest-xdist conflict and deprecated pandas .ix Apr 23, 2019
@nicain nicain force-pushed the hotfix/internal_CI branch from af70603 to 2a8d9ef Compare April 23, 2019 23:49
@nicain nicain requested review from NileGraddis and dyf April 24, 2019 00:28
@nicain
Copy link
Contributor Author

nicain commented Apr 24, 2019

@nicain nicain marked this pull request as ready for review April 24, 2019 00:29
@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #591 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #591   +/-   ##
=======================================
  Coverage   44.94%   44.94%           
=======================================
  Files          92       92           
  Lines       11880    11880           
=======================================
  Hits         5340     5340           
  Misses       6540     6540
Impacted Files Coverage Δ
allensdk/brain_observatory/locally_sparse_noise.py 31.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c029de0...2a8d9ef. Read the comment docs.

Copy link
Contributor

@dyf dyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe double check the session analysis regression test to be safe.

@nicain
Copy link
Contributor Author

nicain commented Apr 24, 2019

maybe double check the session analysis regression test to be safe.

These tests pass, but the nightly has been failing for some time and I would like to get those passing again before this merge, to see if this causes any regressions

@nicain nicain mentioned this pull request Apr 24, 2019
@wbwakeman wbwakeman modified the milestones: 19-04-24, 19-05-01 Apr 24, 2019
@nicain
Copy link
Contributor Author

nicain commented Apr 25, 2019

@nicain nicain merged commit e1b4d58 into master Apr 25, 2019
@nicain nicain deleted the hotfix/internal_CI branch April 26, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants