Skip to content

Add per sweep update for OVS and lots of minor stuff on the way to that #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-b merged 39 commits into from
Jul 17, 2020
Merged

Add per sweep update for OVS and lots of minor stuff on the way to that #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
151e6bd
MIES_BrowserSettingsPanel.ipf: Add testing header
t-b Jul 16, 2020
c9fc76f
Tests: Make STIW_TestDimensions pass again
t-b Jul 15, 2020
cf7f827
Tests: Make TestPlotting more robust
t-b Jul 16, 2020
3261ed6
BSP_HasBoundDevice: SweepBrowsers are always bound
t-b Jul 13, 2020
3be0c0a
OVS_ParseIgnoreList: Fix whitespace in comment
t-b Jul 14, 2020
f43b49e
GetPlainSweepList: Return a numeric wave with just the sweep numbers
t-b Jul 14, 2020
a8ec28c
Databrowser/Sweepbrowser: Unify more control procedures
t-b Jul 14, 2020
4975be7
DataBrowser: Move control procedure setting into macro
t-b Jul 14, 2020
9b05abd
Databrowser: Unify OverlaySweeps control procedure
t-b Jul 14, 2020
a7566db
Databrowser/SweepBrowser: Add generic function for LBN fetching
t-b Jul 14, 2020
7926da2
DB_ResetAndStoreCurrentDBPanel: Add forgotten controls
t-b Jul 14, 2020
098777d
SearchForInvalidControlProcs: Skip controls which can't have a contro…
t-b Jul 14, 2020
05ed273
SearchForInvalidControlProcs: Add option to warn on empty control pro…
t-b Jul 14, 2020
2b27e51
Make GUI control procedures faster
t-b Jul 14, 2020
90e2653
GetOverlaySweepsListWave: Fix comment
t-b Jul 15, 2020
3f134be
OVS_InvertSweepSelection: Remove unused function
t-b Jul 15, 2020
c0d7481
OVS_ChangeSweepSelectionState/OVS_AddToIgnoreList: Remove unused vari…
t-b Jul 15, 2020
1dc0f0a
UpdateSweepPlot: Prefer the generic wrapper
t-b Jul 15, 2020
1384af7
AR_UpdateTracesIfReq: Prefer BSP_GetNumericalValues
t-b Jul 15, 2020
4129e25
DB_UpdateToLastSweep: Fix code alignment
t-b Jul 15, 2020
69b95fa
OVS_ParseIgnoreList: Ignore invalid headstages
t-b Jul 15, 2020
b368654
OVS_GetSweepAndExperiment: Handle invalid index
t-b Jul 15, 2020
19bb7b1
CreateTiledChannelGraph: Make channelSelWave non-optional
t-b Jul 15, 2020
9abf075
BSP_RemoveDisabledChannels: Don't handle non-existing channel selecti…
t-b Jul 15, 2020
e2214eb
BSP_FetchSelectedChannels: Avoid code duplication
t-b Jul 15, 2020
37aa517
PostPlotTransformations: Incorporate layouting as well
t-b Jul 17, 2020
4e1b73b
Add code to remove/add/update single sweeps to the graph
t-b Jul 15, 2020
1bd1722
CreateTiledChannelGraph: Remove unused variables
t-b Jul 15, 2020
1a21bd5
OVS_AddToIgnoreList: Use per-sweep update
t-b Jul 15, 2020
9db853a
Sweepbrowser: Remove the optional index argument of SB_UpdateSweepPlot
t-b Jul 15, 2020
06b0668
DB_FirstAndLastSweepAcquired: Move to BrowserSettings and make it ava…
t-b Jul 15, 2020
fc0b8b1
UpdateSweepPlot: Use it in more places
t-b Jul 15, 2020
3ef1b5b
Databrowser/Sweepbrowser: Unify ChangeSweeps button procedure
t-b Jul 15, 2020
4e6205e
Overlay Sweeps: Don't do a full update when changing the state of a s…
t-b Jul 15, 2020
7aa3a1a
AD_SelectResult: Make it static
t-b Jul 15, 2020
71c8457
BSP_CheckBoxProc_SweepFormula: Don't call UpdateSweepPlot
t-b Jul 15, 2020
e883c5f
OVS_MainListBoxProc: Use per sweep updates
t-b Jul 15, 2020
ffca207
Add incremental update support for overlay sweeps
t-b Jul 15, 2020
2f32f68
Databrowser/Sweepbrowser: Raise versions
t-b Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
253 changes: 78 additions & 175 deletions Packages/MIES/MIES_AnalysisBrowser_SweepBrowser.ipf
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Packages/MIES/MIES_AnalysisFunctions_Dashboard.ipf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ static Function/S AD_GetBaselineFailMsg(anaFuncType, numericalValues, sweepNo, h
End

/// @brief Show the sweeps of the given `index` entry into the listbox
Function AD_SelectResult(win, [index])
static Function AD_SelectResult(win, [index])
string win
variable index

Expand Down
5 changes: 3 additions & 2 deletions Packages/MIES/MIES_ArtefactRemoval.ipf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,11 +370,10 @@ Function AR_ButtonProc_RemoveRanges(ba) : ButtonControl
return 0
End

Function AR_UpdateTracesIfReq(graph, sweepFolder, numericalValues, sweepNo)
Function AR_UpdateTracesIfReq(graph, sweepFolder, sweepNo)
string graph
variable sweepNo
DFREF sweepFolder
WAVE numericalValues

string panelTitle

Expand All @@ -384,6 +383,8 @@ Function AR_UpdateTracesIfReq(graph, sweepFolder, numericalValues, sweepNo)
return NaN
endif

WAVE numericalValues = BSP_GetNumericalValues(graph, sweepNumber = sweepNo)

DFREF singleSweepDFR = GetSingleSweepFolder(sweepFolder, sweepNo)
WAVE ranges = AR_ComputeRanges(singleSweepDFR, sweepNo, numericalValues)
AR_UpdatePanel(panelTitle, ranges, singleSweepDFR)
Expand Down
Loading