Skip to content

Conversation

@rpmcginty
Copy link
Collaborator

Details

This PR upgrades our build tool from pip to uv. Along with it, we have upgraded the formatting / linting tools from isort + black to ruff

Testing

I have run linting and unit tests locally.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.96%. Comparing base (190ac3c) to head (45b4afb).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/aibs_informatics_aws_lambda/main.py 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   91.00%   90.96%   -0.04%     
==========================================
  Files          26       26              
  Lines        1434     1428       -6     
  Branches      122      122              
==========================================
- Hits         1305     1299       -6     
  Misses         98       98              
  Partials       31       31              
Files with missing lines Coverage Δ
.../aibs_informatics_aws_lambda/common/api/handler.py 85.14% <100.00%> (-0.84%) ⬇️
...aibs_informatics_aws_lambda/common/api/resolver.py 94.73% <ø> (-0.06%) ⬇️
src/aibs_informatics_aws_lambda/common/handler.py 94.78% <100.00%> (ø)
src/aibs_informatics_aws_lambda/common/models.py 94.11% <100.00%> (ø)
...ibs_informatics_aws_lambda/handlers/batch/model.py 100.00% <100.00%> (ø)
...atics_aws_lambda/handlers/data_sync/file_system.py 86.74% <ø> (-0.16%) ⬇️
...informatics_aws_lambda/handlers/data_sync/model.py 100.00% <100.00%> (ø)
...matics_aws_lambda/handlers/data_sync/operations.py 92.95% <100.00%> (ø)
...tics_aws_lambda/handlers/demand/context_manager.py 96.59% <100.00%> (+0.02%) ⬆️
...ormatics_aws_lambda/handlers/demand/scaffolding.py 93.33% <100.00%> (ø)
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rpmcginty rpmcginty force-pushed the feature/upgrade-to-uv branch from dce6511 to f9219d2 Compare October 15, 2025 00:11
fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12"]
python-version: ["3.10", "3.11", "3.12", "3.13"]
Copy link
Collaborator

@njmei njmei Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe out of scope, but do we really need to support this many versions of Python for something running on AWS lambda? I can understand the need for something like our OCS CLI, but I'm not sure it makes so much sense for our lambdas which should entirely be under our control right?

The benefits of only supporting/testing 1 (maybe 2) versions is less Github actions worker time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this being a library means that it can be used as a dependency by multiple lambda packages. FWIW we only test highest and lowest resolution for half of the python versions (highest and lowest versions). I could reduce to only 1 if you really think this is a worthwhile cost saving measure.

Copy link
Collaborator

@njmei njmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more nits, but overall LGTM

@rpmcginty rpmcginty merged commit a408532 into main Oct 15, 2025
8 checks passed
@rpmcginty rpmcginty deleted the feature/upgrade-to-uv branch October 15, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants