-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade package to uv #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
- Coverage 91.00% 90.96% -0.04%
==========================================
Files 26 26
Lines 1434 1428 -6
Branches 122 122
==========================================
- Hits 1305 1299 -6
Misses 98 98
Partials 31 31
🚀 New features to boost your workflow:
|
dce6511 to
f9219d2
Compare
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
| python-version: ["3.10", "3.11", "3.12", "3.13"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe out of scope, but do we really need to support this many versions of Python for something running on AWS lambda? I can understand the need for something like our OCS CLI, but I'm not sure it makes so much sense for our lambdas which should entirely be under our control right?
The benefits of only supporting/testing 1 (maybe 2) versions is less Github actions worker time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this being a library means that it can be used as a dependency by multiple lambda packages. FWIW we only test highest and lowest resolution for half of the python versions (highest and lowest versions). I could reduce to only 1 if you really think this is a worthwhile cost saving measure.
src/aibs_informatics_aws_lambda/handlers/data_sync/operations.py
Outdated
Show resolved
Hide resolved
njmei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more nits, but overall LGTM
Details
This PR upgrades our build tool from pip to uv. Along with it, we have upgraded the formatting / linting tools from isort + black to ruff
Testing
I have run linting and unit tests locally.