-
Notifications
You must be signed in to change notification settings - Fork 0
Add support for job_role_arn in the demand execution lambda functions #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 90.96% 90.93% -0.04%
==========================================
Files 26 26
Lines 1428 1423 -5
Branches 122 122
==========================================
- Hits 1299 1294 -5
Misses 98 98
Partials 31 31
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| job_role_arn=demand_execution.execution_platform.aws_batch.job_role | ||
| if demand_execution.execution_platform.aws_batch | ||
| else None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass
job_role_arn from demand execution to BatchJobBuilder
The new plumbing for job roles still reads the field as aws_batch.job_role. The rest of the API uses job_role_arn (e.g., CreateDefinitionAndPrepareArgsRequest.job_role_arn and the new handler signatures), so this lookup will either raise an AttributeError or silently return None, causing the Batch job definition to be registered without the caller’s role even when one was supplied. When a demand execution contains a role ARN, this code path will drop it and the job will execute with the default role instead.
Useful? React with 👍 / 👎.
What's in this Change?
This change utilizes the new batch job role field in demand execution's aws batch execution platform config and passes to the necessary code functions
Testing