Fix on premise tests #581
Merged
Fix on premise tests #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The on-premise tests using the python 3.9 and 3.11 tests are currently not working due to permission issues around the CWD when executing docker run. The reason is that the user id of the user inside the docker image and of that on the machine running github actions is different. By now creating a user with uid/gid 1001 we match what is on the host. But the images are currently only rebuild on demand manually on the machine. We fix that by building them before the run step. The run step is also moved to a script for easier local testing and to avoid code duplication. And finally the Dockerfile is used with a ARG'ed FROM to avoid duplication.
t-b
force-pushed
the
fix-on-premise-tests
branch
from
3b00b72 to
bb957a9
Compare
t-b
added a commit
that referenced
this pull request
Aug 27, 2025
The on-premise tests were fixed in 078bda8 (Merge pull request #581 from AllenInstitute/fix-on-premise-tests, 2025-08-26) and also passed on master [1]. Now they are not passing again with an error like: credentials = dict((k, os.environ.get(env_var, LIMS_DB_CREDENTIAL_DEFAULTS[env_var])) for k, env_var in LIMS_DB_CREDENTIAL_MAP.items()) KeyError: 'LIMS_PASSWORD' The dict LIMS_DB_CREDENTIAL_DEFAULTS does not contain an entry with "LIMS_PASSWORD" as key which should be okay as we are always having that in the envrionment. But this seems to be racy as sometimes we try indexing LIMS_DB_CREDENTIAL_DEFAULTS with "LIMS_PASSWORD" anyway. Let's fix that by adding an entry do LIMS_DB_CREDENTIAL_DEFAULTS. [1]: https://github.com/AllenInstitute/ipfx/actions/runs/17247644153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #573