Skip to content

Conversation

@rcpeene
Copy link
Collaborator

@rcpeene rcpeene commented Jan 18, 2023

…as dataframe #129

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -83,7 +83,7 @@
"name": "stderr",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #24.    ax.plot(bins[:-1], hist)

Great plot


Reply via ReviewNB

@@ -83,7 +83,7 @@
"name": "stderr",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to choose a time with a clear sensory response in the image at time zero? How did you choose this time?


Reply via ReviewNB

@@ -83,7 +83,7 @@
"name": "stderr",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    ax.plot(peak_waveform)

The x-axis seems wrong. I don't think a spike lasts 30 s. Perhaps you need to pass in the x-axis time array ?


Reply via ReviewNB

@@ -83,7 +83,7 @@
"name": "stderr",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably better visualize by an image where channel number is the vertical axis and xaxis is time.


Reply via ReviewNB

@@ -83,7 +83,7 @@
"name": "stderr",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    colors = plt.cm.viridis(np.linspace(0, 1, len(np.transpose(units["waveform_mean"][unit_idx])) ))

Same than previous plot. An image might be more informative. Having the time as a colorer is a bit confusing to me.


Reply via ReviewNB

@rcpeene rcpeene merged commit ad9bfe3 into dev Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants