-
Notifications
You must be signed in to change notification settings - Fork 25
Changed notebook to operate on units table without converting to pand… #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -83,7 +83,7 @@ | |||
| "name": "stderr", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -83,7 +83,7 @@ | |||
| "name": "stderr", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to choose a time with a clear sensory response in the image at time zero? How did you choose this time?
Reply via ReviewNB
| @@ -83,7 +83,7 @@ | |||
| "name": "stderr", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #2. ax.plot(peak_waveform)
The x-axis seems wrong. I don't think a spike lasts 30 s. Perhaps you need to pass in the x-axis time array ?
Reply via ReviewNB
| @@ -83,7 +83,7 @@ | |||
| "name": "stderr", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably better visualize by an image where channel number is the vertical axis and xaxis is time.
Reply via ReviewNB
| @@ -83,7 +83,7 @@ | |||
| "name": "stderr", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #2. colors = plt.cm.viridis(np.linspace(0, 1, len(np.transpose(units["waveform_mean"][unit_idx])) ))
Same than previous plot. An image might be more informative. Having the time as a colorer is a bit confusing to me.
Reply via ReviewNB
…as dataframe #129