Skip to content

make hosts all lowercase#269

Merged
neuromusic merged 7 commits intomasterfrom
feature/lowercase_hostnames
Jul 12, 2018
Merged

make hosts all lowercase#269
neuromusic merged 7 commits intomasterfrom
feature/lowercase_hostnames

Conversation

@neuromusic
Copy link
Copy Markdown
Contributor

@neuromusic neuromusic commented Jul 11, 2018

No description provided.

@neuromusic
Copy link
Copy Markdown
Contributor Author

neuromusic commented Jul 11, 2018

this might break some tests...

@neuromusic
Copy link
Copy Markdown
Contributor Author

neuromusic commented Jul 12, 2018

@dougollerenshaw tests are passing. please review. note: I've refactored get_rig_id into two separate functions: get_rig_id to get the rig id from the (case insensitive) computer name and get_computer_name for to get the lowercase computer name from the rig id

@neuromusic neuromusic merged commit cd1518f into master Jul 12, 2018
@neuromusic neuromusic deleted the feature/lowercase_hostnames branch July 12, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dougollerenshaw dougollerenshaw dougollerenshaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@neuromusic @dougollerenshaw