fixes metadata on legacy loading#281
Merged
neuromusic merged 3 commits into0.4.xfrom Jul 18, 2018
Merged
Conversation
Contributor
Author
|
fixes #280 |
Contributor
Author
|
hmm. now failing for a different reason on the file referenced in #280 |
Contributor
Author
|
ok, this should work now. we'll tag it once merged into the 0.4.x branch |
ryyesterday
approved these changes
Jul 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR also adds tests to ensure that QC doesn't crash when loading the canonical data.
cc @Ryval @nicain