Skip to content

resloved empty directory name issue #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2019
Merged

resloved empty directory name issue #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "create-react-webpack",
"version": "0.1.0",
"version": "0.1.1",
"description": "create-react-webpack ",
"main": "scripts/create.js",
"bin": {
Expand Down
4 changes: 3 additions & 1 deletion scripts/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ var args = process.argv.slice(2);
var dirName = args[0];
var end_to_end = args[1];

if (dirName[0].match("^[A-Z0-9]")) {
if (dirName === "undefined") {
throw new Error(ErrorMessage("directory name can't be empty"));
} else if (dirName[0].match("^[A-Z0-9]")) {
throw new Error(
ErrorMessage("directory name can't start from capital letters ")
);
Expand Down