CA1826 (Do not use Enumerable methods on indexable collections)#27
Closed
kirsan31 wants to merge 1 commit into
Closed
CA1826 (Do not use Enumerable methods on indexable collections)#27kirsan31 wants to merge 1 commit into
kirsan31 wants to merge 1 commit into
Conversation
…ad use the collection directly) fix.
Alparse
added a commit
that referenced
this pull request
May 27, 2026
…ode quality fixes (Issues #24, #29, #30, PRs #25-28, #31) - Pin databento-cpp to v0.58.0 to prevent broken intermediate builds (#24) - Deprecate caching API with [Obsolete] attributes, guide to WithFileSource() (#29) - PlaybackController implements IDisposable for SemaphoreSlim cleanup (#29) - StreamAsync XML docs for live vs backtest mode behavior (#30) - Fix S&P XML escaping and BatchSubmitJobAsync cref (PR #25) - Remove CA1805 default initializations across 10 files (PR #26) - Replace FirstOrDefault() with indexer in FileDataSource (PR #27) - Fix FormUrlEncodedContent disposal in retry loops, add ConfigureAwait(false) (PR #28) - Remove dead _apiKey field from LiveClient and ReferenceClient (PR #31)
Owner
|
Thanks @kirsan31 — applied in v5.3.2. Direct indexer after the count check is the right call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CA1826 (Do not use Enumerable methods on indexable collections. Instead use the collection directly) fix.
SymbolMapping.IntervalsisIReadOnlyList. So in performance reason we need to use index directly instead ofFirstOrDefault.