Conversation
- Introduced `ErrWriterNil` for handling `nil` writer cases. - Enhanced `PrintSimpleWriter` and `PrintLogoWriter` with additional validations. - Improved test coverage with new test cases for `BrokenNIO` scenarios. - Added `t.Parallel()` to applicable test cases for better concurrency.
Codecov Report✅ All modified and coverable lines are covered by tests.
|
- Updated `fmt.Errorf` calls to provide more descriptive error messages. - Modified relevant error assertions in tests to align with the updated error messages. - Added a changelog entry for improved error message clarity.
- Introduced `TestLogoWriterNil` to verify behavior when writer is `nil`. - Added `t.Parallel()` for better test concurrency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ErrWriterNilfor handlingnilwriter cases.PrintSimpleWriterandPrintLogoWriterwith additional validations.BrokenNIOscenarios.t.Parallel()to applicable test cases for better concurrency.