Merged
Conversation
Adds a ⚙ toolbar button that opens a form for the four probe.yaml
fields users actually touch: agent.port, defaults.timeout,
device.ios_device_id, device.android_device_id.
Backend (studio/workspace_settings.go):
LoadWorkspaceSettings reads probe.yaml via internal/config and
surfaces the four managed fields. SaveWorkspaceSettings rereads
the file as a raw map[string]any, mutates only the keys we manage,
and writes back — so a power user with complex probe.yaml (cloud
config, plugins, recipes_folder, etc.) doesn't lose anything by
using the UI. Empty/zero fields are dropped from the YAML so we
don't litter probe.yaml with `agent: {}` after the user clears a
field.
Validation: agent.port range-checked, defaults.timeout parsed as a
Go duration before any disk write — invalid input fails fast with a
clear error.
Frontend: settings overlay matches the help/wifi modal shape;
Escape closes all three.
Deliberately scoped tight — extending the field set is cheap once
the plumbing exists, but landing a small form first beats arguing
about which 20 fields to expose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a ⚙ toolbar button that opens a form for the four probe.yaml fields users actually touch. Saves write back to `probe.yaml` in the active workspace, preserving all other keys.
v0.7.1 PR 2 of 3.
Fields exposed
Deliberately tight — extending the field set is cheap once the plumbing exists, but landing a small form first beats arguing about which 20 fields to expose.
Implementation notes
Test plan