Feature/add battle points for clans 630 #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlayJeri
previously requested changes
Sep 5, 2025
Member
PlayJeri
left a comment
PlayJeri
left a comment
There was a problem hiding this comment.
Nice work.
Only thing I want to change is that the eventsHandler sends playerId to clan rewarder and not clanId. So the rewarder has to make another db query. Since the eventsHandler already has the clanId known it should send that to rewardForClanEvent and then remove the player query.
| if (playerErrors) return [null, playerErrors]; | ||
|
|
||
| const [, clanEventErrors] = await this.clanEventHandler.handleClanEvent( | ||
| player_id, |
| * @returns true if clan was rewarded successfully | ||
| */ | ||
| async rewardForClanEvent( | ||
| player_id: string, |
Member
There was a problem hiding this comment.
Take in clan_id instead of player_id
| await this.playerService.readOneById<PlayerDto>(player_id); | ||
| if (playerErrors) return [null, playerErrors]; | ||
|
|
||
| if (!player.clan_id) { |
PlayJeri
dismissed
their stale review
My bad. The requested change isn't even possible.
Contributor
Author
|
@PlayJeri no needed the player / clan id change? |
Member
No need. I dont know what i was thinking earlier. My apologies 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
As a clan member, I want to get points for my clan when I win a battle, so that my clan can rise in a battle leaderboard.
Change list