Skip to content

Fix duplicate AdPosterDto by changing dto name #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hoan301298 merged 1 commit into from
Nov 26, 2025
Merged

Fix duplicate AdPosterDto by changing dto name #733

hoan301298 merged 1 commit into from
Nov 26, 2025

Conversation

@hoan301298
Copy link
Member

@hoan301298 hoan301298 commented Nov 24, 2025 •
edited
Loading

Brief description

Following issue: Bug: Duplicate DTO #680
ERROR Duplicate DTO detected: "AdPosterDto" is defined multiple times with different schemas.
Fix: Renamed AdPosterDto with different names (FleaMarketAdPosterDto & ClanAdPosterDto)

Change list

  • tests/fleaMarket/stall/StallService/updateAdPosterByClanId.test.ts
  • tests/fleaMarket/stall/data/AdPosterDtoBuilder.ts
  • clan/dto/stall.dto.ts
  • fleaMarket/stall/dto/adPoster.dto.ts
  • fleaMarket/stall/stall.controller.ts
  • fleaMarket/stall/stall.service.ts

@hoan301298 hoan301298 added the bug Something isn't working label Nov 24, 2025
PlayJeri
PlayJeri approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@PlayJeri PlayJeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@github-project-automation github-project-automation bot moved this from Backlog to Done in Altzone-Server Nov 25, 2025
@hoan301298 hoan301298 merged commit f059001 into dev Nov 26, 2025
4 checks passed
@hoan301298 hoan301298 deleted the bug/duplicate-dto branch November 26, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PlayJeri PlayJeri PlayJeri approved these changes

@MikhailDeriabin MikhailDeriabin Awaiting requested review from MikhailDeriabin MikhailDeriabin is a code owner

@jkrizsan jkrizsan Awaiting requested review from jkrizsan

Assignees

No one assigned

Labels

bug Something isn't working

Projects

Altzone-Server
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoan301298 @PlayJeri