Skip to content

Sakari/feature/299 create a navigation sidebar component for clan mainpage#376

Merged
Jonroi merged 36 commits intodevfrom
sakari/feature/299-Create-a-Navigation-Sidebar-Component-for-Clan-Mainpage
Jan 30, 2025
Merged

Sakari/feature/299 create a navigation sidebar component for clan mainpage#376
Jonroi merged 36 commits intodevfrom
sakari/feature/299-Create-a-Navigation-Sidebar-Component-for-Clan-Mainpage

Conversation

@Skoivumaki
Copy link
Copy Markdown
Member

📄 Pull Request Overview

closes #299

The issue initially began as a sidebar component for the clan page, but since the same sidebar is used throughout Figma, I decided to make it as versatile as possible.

🔧 Changes Made

  1. Updated the visual look of NavMenuWithDropdowns to match the current Figma design.
  2. Added new feature to NavMenuWithDropdowns:
    • staticDropdown: Determines if the first dropdown element remains static and always open.
    • titleAsActive: Uses the active dropdown item title as the main dropdown title if the item's link path matches the current router path.
  3. Added a new feature to DropdownWrapper:
    • staticDropdown: Specifies whether the first dropdown element remains static and always open.
    • staticTitle: Uses the title provided by the interface if staticDropdown is set to true.
  4. Refactored components to integrate these changes.
  5. Added/updated storybook entries for DropdownWrapper and NavMenuWithDropdowns
  6. Added jsdocs for NavMenuWithDropdowns

Preview of sidebar in clan page:
image


Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected.
  • JSDoc: I have added or updated JSDoc comments for all relevant code.
  • Debugging: No console.log() or other debugging statements are left.
  • Clean Code: Removed commented-out or unnecessary code.
  • Tests: Added new tests or updated existing ones for the changes made.
  • Documentation: Documentation has been updated (if applicable).

📝 Additional Information

Provide any additional context or information that reviewers may need to know:

Build may fail since this branch was created before the layout type problem was fixed.
To test goto: http://localhost:5173/en/admin

…t-for-Clan-Mainpage' of https://github.com/Alt-Org/Altzone-WebPages into sakari/feature/299-Create-a-Navigation-Sidebar-Component-for-Clan-Mainpage
…wn" a static menu with set title. Note: menu needs to be set always open for static menu to work...
Copy link
Copy Markdown
Contributor

@Jonroi Jonroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is done in the most perfect way.
For our last conversation we should plan for refactoring the v2 models to handle all new designs. displaying the table on the admin page is the most beautiful thing ever done :D

Admin Page Table

@Jonroi Jonroi merged commit ba44d4b into dev Jan 30, 2025
@Jonroi Jonroi deleted the sakari/feature/299-Create-a-Navigation-Sidebar-Component-for-Clan-Mainpage branch January 30, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants