Conversation
Updated the strings in cookieConsent.json and modified the CookieConsent component and css to match the new changes.
Updated the strings in cookieConsent.json and modified the CookieConsent component and css to match the new changes.
Privacy and Cookies page modifications(without ethnical information)
…idelines' of https://github.com/Alt-Org/Altzone-WebPages into liisa/chore/617-update-cookie-banner-and-legal-pages-guidelines
Added JSDoc for an entire file
…idelines' of https://github.com/Alt-Org/Altzone-WebPages into liisa/chore/617-update-cookie-banner-and-legal-pages-guidelines
Rutjake
left a comment
There was a problem hiding this comment.
Great work on this overall! The implementation is looking solid, but I spotted a couple of things that could use a bit of polish before we merge:
First, we’re seeing some layout issues on mobile and tablet. On mobile, the CookieConsent text is partially hidden behind the buttons, and on tablet, the modal overflows at the bottom, making some content invisible. To help catch these across all breakpoints, I’d highly recommend using the Responsively App, it’s great for seeing how the layout behaves on multiple screens at once.
Also, there’s a small formatting inconsistency in cookies.json. Some list items have a space after the bullet points while others don't. It would be great to standardize these to match the style in privacy.json. Even though this concept is getting an update soon, it’s best to keep the data clean while we’re already touching the code.
Make cookie banner responsive for mobile and tablet view
Return back banner button positions and header
Fix formatting inconsistency in cookies.json
Rutjake
left a comment
There was a problem hiding this comment.
Good job, the most important things have been highlighted. This will be redesigned in the future as content and features change.
Skoivumaki
left a comment
There was a problem hiding this comment.
Remove padding-right on mobile. Its causing content to be off-center. I also noticed the text is not center aligned on Firefox, but looks correct on Responsively? 🤔
Removed padding-right on mobile and fixed content to center-aligned in all small screens.
📄 Pull Request Overview
Closes #617
🔧 Changes Made
Updated cookie banner to match new banner guidelines
Modified localization files i18n
privacy.jsonandcookie.jsonto match privacy and ccokie guidlines(without ethnical documantation)✅ Checklist Before Submission
CookieConsentV3.tsx📝 Additional Information
Provide any additional context or information that reviewers may need to know: