Skip to content

Liisa/chore/617 update cookie banner and legal pages guidelines#631

Merged
davylis merged 10 commits intodevfrom
liisa/chore/617-update-cookie-banner-and-legal-pages-guidelines
Mar 12, 2026
Merged

Liisa/chore/617 update cookie banner and legal pages guidelines#631
davylis merged 10 commits intodevfrom
liisa/chore/617-update-cookie-banner-and-legal-pages-guidelines

Conversation

@davylis
Copy link
Copy Markdown
Contributor

@davylis davylis commented Feb 25, 2026

📄 Pull Request Overview

Closes #617

🔧 Changes Made

  1. Updated cookie banner to match new banner guidelines

  2. Modified localization files i18n privacy.json and cookie.json to match privacy and ccokie guidlines(without ethnical documantation)


Checklist Before Submission

  • Functionality: Tested at /cookies and /privacy
  • JSDoc: I have added JSDoc comments to CookieConsentV3.tsx
  • Debugging: Clean
  • Clean Code: Clean
  • Tests: N/A
  • Documentation: N/A

📝 Additional Information

Provide any additional context or information that reviewers may need to know:

  • Screenshots:
Screenshot 2026-02-25 at 16 48 32
Screenshot 2026-02-25 at 16 47 46
Screenshot 2026-02-25 at 16 47 57
  • Dependencies: None
  • Known Issues: No ethnical guidlines yet

Updated the strings in cookieConsent.json and modified the CookieConsent component and css to match the new changes.
Updated the strings in cookieConsent.json and modified the CookieConsent component and css to match the new changes.
Privacy and Cookies page modifications(without ethnical information)
…idelines' of https://github.com/Alt-Org/Altzone-WebPages into liisa/chore/617-update-cookie-banner-and-legal-pages-guidelines
Added JSDoc for an entire file
…idelines' of https://github.com/Alt-Org/Altzone-WebPages into liisa/chore/617-update-cookie-banner-and-legal-pages-guidelines
Copy link
Copy Markdown
Contributor

@Rutjake Rutjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this overall! The implementation is looking solid, but I spotted a couple of things that could use a bit of polish before we merge:

First, we’re seeing some layout issues on mobile and tablet. On mobile, the CookieConsent text is partially hidden behind the buttons, and on tablet, the modal overflows at the bottom, making some content invisible. To help catch these across all breakpoints, I’d highly recommend using the Responsively App, it’s great for seeing how the layout behaves on multiple screens at once.

Image

Also, there’s a small formatting inconsistency in cookies.json. Some list items have a space after the bullet points while others don't. It would be great to standardize these to match the style in privacy.json. Even though this concept is getting an update soon, it’s best to keep the data clean while we’re already touching the code.

davylis added 3 commits March 5, 2026 12:40
Make cookie banner responsive for mobile and tablet view
Return back banner button positions and header
Fix formatting inconsistency in cookies.json
@davylis davylis self-assigned this Mar 5, 2026
@davylis davylis requested a review from Rutjake March 5, 2026 12:07
Copy link
Copy Markdown
Contributor

@Rutjake Rutjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, the most important things have been highlighted. This will be redesigned in the future as content and features change.

Copy link
Copy Markdown
Member

@Skoivumaki Skoivumaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove padding-right on mobile. Its causing content to be off-center. I also noticed the text is not center aligned on Firefox, but looks correct on Responsively? 🤔

Removed padding-right on mobile and fixed content to center-aligned in all small screens.
@davylis davylis requested a review from Skoivumaki March 11, 2026 09:29
@davylis davylis merged commit d02e8f6 into dev Mar 12, 2026
3 checks passed
@davylis davylis deleted the liisa/chore/617-update-cookie-banner-and-legal-pages-guidelines branch March 12, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants