Skip to content

Pre-release review findings: dead code, undefined display bugs, missing driver tests, doc gaps #579

@anandgupta42

Description

@anandgupta42

Context

During pre-release validation for v0.5.15, a 5-persona review team identified several issues that should be addressed before release:

Issues

Code fixes (pre-release)

  1. Duplicate altimate_change end markers in prompt.ts at lines 812 and 962 — confuses Marker Guard CI
  2. password: "secret" in test fixtures — 3 instances in feature-discovery-e2e.test.ts inconsistent with cleanup in connections.test.ts
  3. Dead code in classifySkillTrigger() — returns "llm_selected" for unknown triggers instead of "unknown", making the "unknown" variant dead code
  4. Unused "schema_not_indexed" type in feature_suggestion telemetry event union — declared but never used

Undefined display bugs

  1. sql-translate.tssource_dialect/target_dialect without null guards
  2. dbt-manifest.tsmodel.name, source.source_name, source.name without null guards; result.error not propagated to metadata
  3. dbt-lineage.tsmodel_name, confidence without null guards
  4. altimate-core-column-lineage.ts / altimate-core-track-lineage.tsedge.source/edge.target without null guards

Missing test coverage

  1. No unit tests for driver changes — DuckDB retry logic, MongoDB pipeline blocking, PostgreSQL/Redshift password validation, registry unsupported DB hints

Documentation gaps

  1. DuckDB concurrent access retry behavior undocumented
  2. MongoDB blocked operators ($out, $merge, $function, $accumulator) undocumented
  3. Known-unsupported databases (ClickHouse, Cassandra, CockroachDB, TimescaleDB) undocumented

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions