Conversation
Claude Code ReviewThis repository is configured for manual code reviews. Comment |
624da3a to
59af958
Compare
6a2ba6b to
0e78386
Compare
arora-saurabh448
left a comment
There was a problem hiding this comment.
-
Need to Remove or Update -> .github/CODEOWNERS (currently points to opencode users)
-
Need to remove or update -> .github/VOUCHED.td
-
Verify if the templates are required in .github folder
-
experiments/ folder needs to be removed or updated
-
github/ folder for Github actions needs to be made consistent - terminal commands still mention altimate-code instead of altimate standalone
-
Security.md needs to be updated to remove opencode contact email and put ours instead. It also mentions - Report a Vulnerability tab, which we do not have and the associated link is broken(404). Can either update on the basis of this or remove this section entirely.
-
LICENSE - says Copyright Opencode 2025. It should say both -
Copyright (c) 2026 Altimate AI
Copyright (c) 2026 opencode
Kilo also does the same - https://github.com/Kilo-Org/kilocode/blob/main/LICENSE
.github/meta/commit.txt
Outdated
There was a problem hiding this comment.
Do we need this file? This has information about removal of files/content as logs.
There was a problem hiding this comment.
Good catch! Removed it from tracking and added .github/meta/ to .gitignore. This was a scratch file used for commit messages — shouldn't be committed.
2637146 to
b2d410c
Compare
|
Addressed all review items:
Also fixed:
|
- Remove internal planning docs (FEATURES_*.md, IMPLEMENTATION_PLAN.md, PLATFORM_ENGINEER_SIMULATION.md, STATS.md) - Remove internal scripts (beta.ts, duplicate-pr.ts, stats.ts) - Remove internal CI workflows (beta.yml, stats.yml) - Remove `.github/TEAM_MEMBERS` (internal employee list) - Remove `.zed/` (single dev's editor config) - Remove `docs/design/` (internal product strategy) - Move `RELEASING.md` to `docs/` - Fix `pr-management.yml`: remove broken `check-duplicates` job, keep `add-contributor-label` - Fix `opencode.yml`: replace self-hosted runner with `ubuntu-latest` - Standardize internal placeholder URLs to `altimate-code.internal` Closes #207
b2d410c to
7878eba
Compare
| .describe( | ||
| "Automatically enhance prompts with AI before sending (default: false). Uses a small model to rewrite rough prompts into clearer versions.", | ||
| ), | ||
| // altimate_change end |
There was a problem hiding this comment.
Bug: An extra // altimate_change end comment in config.ts creates a mismatch with start markers, which will cause the CI merge guard test to fail.
Severity: HIGH
Suggested Fix
Remove the extraneous // altimate_change end comment from line 1269 in packages/opencode/src/config/config.ts to ensure the number of 'start' and 'end' markers is equal.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/opencode/src/config/config.ts#L1269
Potential issue: An extra `// altimate_change end` comment was added in `config.ts`,
creating an imbalance with `// altimate_change start` comments. The file now contains 9
'start' markers but 10 'end' markers. This will cause the `upstream-merge-guard.test.ts`
CI check, which validates that these markers are balanced in all TypeScript source
files, to fail. The failure of this automated integrity check will prevent the pull
request from being merged.
Did we get this right? 👍 / 👎 to inform future reviews.
| startsWith(github.event.comment.body, '/altimate') || | ||
| contains(github.event.comment.body, ' /ac') || | ||
| startsWith(github.event.comment.body, '/ac') | ||
| runs-on: blacksmith-4vcpu-ubuntu-2404 | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| id-token: write | ||
| contents: read |
There was a problem hiding this comment.
Bug: A script executed during the release CI workflow (release.yml) attempts to read the deleted .github/TEAM_MEMBERS file, which will cause the release process to fail.
Severity: CRITICAL
Suggested Fix
Remove the code from packages/script/src/index.ts that reads the now-deleted .github/TEAM_MEMBERS file to prevent the runtime error in the CI release workflow.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/opencode.yml#L13-L19
Potential issue: The file `.github/TEAM_MEMBERS` was deleted, but the script at
`packages/script/src/index.ts` attempts to read it during module initialization. This
script is a dependency for other build and publish scripts (`build.ts`, `publish.ts`)
that are executed by the `release.yml` CI workflow. When the release workflow runs, it
will trigger the execution of these scripts, leading to a runtime error because the
required file is missing. This will cause the release pipeline to fail.
Did we get this right? 👍 / 👎 to inform future reviews.
What does this PR do?
Cleans up the repository for open-source release by removing internal files, fixing CI workflows, and standardizing branding.
Removed:
FEATURES_*.md,IMPLEMENTATION_PLAN.md,PLATFORM_ENGINEER_SIMULATION.md,STATS.md)beta.ts,duplicate-pr.ts,stats.ts)beta.yml,stats.yml).github/TEAM_MEMBERS(internal employee list).zed/(single dev editor config)docs/design/(internal product strategy)Fixed:
pr-management.yml: removed brokencheck-duplicatesjob (referenced deleted script), keptadd-contributor-labelopencode.yml: replaced self-hostedblacksmithrunner withubuntu-latestopencode.internal→altimate-code.internalMoved:
RELEASING.md→docs/RELEASING.mdType of change
Issue for this PR
Closes #207
How did you verify your code works?
pr-management.ymlretains the usefuladd-contributor-labeljobopencode.internalreferences updated toaltimate-code.internalChecklist