fix: CI test failures for TypeScript and Python jobs#23
Merged
anandgupta42 merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
Two issues: 1. TypeScript permission-task tests: test fixture wrote config to `opencode.json` but the config loader only looks for `altimate-code.json`. Updated fixture to use correct filename. 2. Python tests: `pytest: command not found` because pyproject.toml had no `dev` optional dependency group. Added `dev` extras with pytest and ruff. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment on lines
+27
to
32
| path.join(dirpath, "altimate-code.json"), | ||
| JSON.stringify({ | ||
| $schema: "https://opencode.ai/config.json", | ||
| $schema: "https://altimate-code.dev/config.json", | ||
| ...options.config, | ||
| }), | ||
| ) |
There was a problem hiding this comment.
Bug: The writeConfig() test helper defaults to the old opencode.json filename, causing tests to run with an empty configuration instead of the intended one.
Severity: MEDIUM
Suggested Fix
Update the default name parameter in the writeConfig() helper function located in packages/altimate-code/test/config/config.test.ts from "opencode.json" to "altimate-code.json". Review call sites of this helper to ensure they use the correct configuration file.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/altimate-code/test/fixture/fixture.ts#L27-L32
Potential issue: The configuration filename was updated from `opencode.json` to
`altimate-code.json`. However, a test helper function, `writeConfig()` in
`config.test.ts`, still defaults to writing to the old `opencode.json` filename. The
configuration loader no longer searches for this old filename and will silently return
an empty configuration object when it's not found. Consequently, tests that rely on this
helper function without specifying the new filename will run with an empty
configuration, potentially masking bugs in configuration-dependent logic and allowing
tests to pass when they should be failing.
Did we get this right? 👍 / 👎 to inform future reviews.
anandgupta42
added a commit
that referenced
this pull request
Mar 17, 2026
Two issues: 1. TypeScript permission-task tests: test fixture wrote config to `opencode.json` but the config loader only looks for `altimate-code.json`. Updated fixture to use correct filename. 2. Python tests: `pytest: command not found` because pyproject.toml had no `dev` optional dependency group. Added `dev` extras with pytest and ruff. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencode.jsonbut the config loader (after the rename) only looks foraltimate-code.json. Updated the fixture to write to the correct filename.pytest: command not foundbecausepyproject.tomlhad nodevoptional dependency group. Addeddev = ["pytest>=7.0", "ruff>=0.1"]sopip install -e ".[dev]"works.Test plan
bun test test/permission-task.test.ts— all 21 tests pass locally🤖 Generated with Claude Code