fix: dbt tool regression — schema format mismatch, silent failures, wrong results by anandgupta42 · Pull Request #263 · AltimateAI/altimate-code

anandgupta42 · 2026-03-18T15:17:17Z

What does this PR do?

Fixes 11 broken/degraded dbt tools reported in #261 by addressing two root causes:

Schema format mismatch (root cause for 9 tools): schema-resolver.ts passed flat schema_context ({"table": {"col": "TYPE"}}) directly to Schema.fromJson(), which expects the Rust SchemaDefinition format ({"tables": {"table": {"columns": [{"name": "col", "type": "TYPE"}]}}}). The parse silently failed, falling back to an empty schema.
Field name mismatches (6 tools): Tool formatters referenced wrong field names from the Rust napi output (e.g., grade vs overall_grade, suggestions vs rewrites, has_breaking vs has_breaking_changes).

Tools fixed:

sql_rewrite / lineage_check — schema parse errors → now work
altimate_core_schema_diff — "Schemas are identical" bug → now detects changes
sql_analyze — "Unknown error" → now shows found issues
altimate_core_grade — "Grade: undefined" → now shows A-F grade
altimate_core_fix / altimate_core_rewrite — empty results → now work with schema
altimate_core_column_lineage / altimate_core_testgen / altimate_core_complete — empty results → now work with schema

Type of change

Bug fix (non-breaking change which fixes an issue)

Issue for this PR

Closes #261

How did you verify your code works?

Added 15 unit tests for schema format normalization (schema-resolver.test.ts)
Added 10 unit tests for tool formatter logic (tool-formatters.test.ts)
Added 4 integration tests for flat/array schema resolution (altimate-core-native.test.ts)
All 25 new tests pass; no regressions in existing 631 passing tests
biome check clean on all modified files
turbo typecheck passes

Checklist

My code follows the project's coding standards
I've tested my changes locally
I've added tests for my changes
I've updated documentation if needed
My changes don't introduce new warnings

🤖 Generated with Claude Code

…rong results (#261) Root cause: `schema-resolver.ts` passed flat schema_context (`{"table": {"col": "TYPE"}}`) directly to `Schema.fromJson()`, which expects the Rust `SchemaDefinition` format (`{"tables": {"table": {"columns": [{"name": "col", "type": "TYPE"}]}}}`). The parse silently failed, falling back to an empty schema, causing all schema-dependent tools to produce empty/wrong results. Fixes: - `schema-resolver.ts`: Auto-detect and normalize 3 schema_context variants (flat map, array-of-columns, SchemaDefinition) before calling `Schema.fromJson()` - `sql-analyze.ts`: Check `result.error` instead of `!result.success` to distinguish "issues found" from "analysis failed" - `altimate-core-grade.ts`: Map Rust field names (`overall_grade`, `scores.overall`) instead of `grade`/`score` - `altimate-core-complete.ts`: Use `data.items` (Rust field) with fallback to `data.suggestions` - `altimate-core-schema-diff.ts`: Use `has_breaking_changes` (Rust) and format tagged enum changes correctly - `altimate-core-rewrite.ts`: Use `data.suggestions` (Rust) with fallback to `data.rewrites` - `altimate-core-fix.ts`: Map `fixes_applied`/`unfixable_errors` (Rust fields) instead of `changes`/`errors` - `altimate-core-column-lineage.ts`: Show `column_dict` and use `lens_type` (Rust) for transform info - `sql/register.ts`: Populate `can_auto_apply`, `original_fragment`, `rewritten_fragment` in `sql.rewrite` handler Closes #261 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

packages/opencode/src/altimate/native/schema-resolver.ts

Full simulation of 77 tests across all altimate-core tools revealed 6 more field name mismatches between Rust napi output and TS formatters: - `altimate_core.transpile`: QUALIFY post-processing checked `data.sql` but Rust returns `transpiled_sql` (array) - `altimate_core.resolve_term`: Rust returns array, `toData()` converts to `{'0': ...}` object — now wraps as `{ matches: [...] }` - `altimate_core_classify_pii`: checked `data.findings` but Rust returns `columns` with `classification`/`suggested_masking` fields - `altimate_core_query_pii`: checked `data.exposures` but Rust returns `pii_columns` with `risk_level`/`suggested_alternatives` - `altimate_core_testgen`: test cases have `inputs`/`expected` fields, not `sql` — formatter now shows input values and expectations - `altimate_core_prune_schema`: checked `data.pruned` but Rust returns `pruned_schema_yaml`/`relevant_tables`/`tables_pruned` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Two new test files exercising all 36 altimate-core napi functions through the dispatcher layer: - `issue-261-e2e.test.ts`: 14 tests reproducing all 11 broken tools from #261 plus schema format variant tests - `edge-cases-simulation.test.ts`: 76 tests covering empty inputs, complex SQL patterns (nested subqueries, CTEs, window functions, correlated subqueries), column lineage through transformations, schema diff with large schemas, PII detection, multi-dialect transpilation, DDL roundtrip, equivalence checks, policy enforcement, and migration safety analysis Total: 192 tests, 404 assertions, 0 failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

packages/opencode/src/altimate/tools/altimate-core-query-pii.ts

Stress simulation covering: SQL pattern variants (recursive CTEs, LATERAL joins, GROUPING SETS), lint anti-pattern detection, column lineage through 10 transformation types, schema diff mutation matrix (100-column tables, special chars), 10-dialect transpile matrix, grading consistency, fuzzy fix matching, testgen feature coverage, cursor-position completions, PII detection, and term resolution. Also fixes schema-resolver to skip tables with empty column lists (Rust engine requires >= 1 column per table). Total simulation suite: 288 tests, 867 assertions, 0 failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Moved all simulation tests into proper e2e test files following the project convention (`*-e2e.test.ts` in `test/altimate/`): - `altimate-core-e2e.test.ts` — 100 tests: all dispatcher methods, schema format variants, error recovery, complex SQL patterns - `altimate-core-stress-e2e.test.ts` — 80 tests: dialect matrix, fuzzy fix matching, grading consistency, testgen coverage, cursor completions, PII detection, lineage tracing, schema diffs - `issue-261-e2e.test.ts` — 14 tests: regression tests for #261 Removed standalone simulation files (full-simulation, edge-cases, stress-simulation) — content consolidated into the e2e files above. Total e2e suite: 180 tests, 539 assertions, 0 failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

… PII field fallbacks 1. `isSchemaDefinitionFormat`: now validates that values under `tables` contain a `columns` array, preventing false positives when a flat schema has a table literally named "tables" 2. `formatQueryPii` / `formatClassifyPii`: added fallbacks for missing `table`/`column` properties to prevent "undefined.column_name" output 3. Added test for the "tables" false-positive scenario Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

anandgupta42 · 2026-03-18T16:22:48Z

packages/opencode/src/altimate/tools/altimate-core-fix.ts

      lines.push("\nChanges applied:")
-      for (const c of data.changes) {
-        lines.push(`  - ${c.description ?? c}`)
+      for (const c of fixes) {


Fixed in commit 0bf5bedc8. Changed the condition from data.fixed && data.fixed_sql to data.fixed_sql && data.fixed !== false — so a valid fixed_sql is shown when fixed is either true or absent (undefined). Only an explicit fixed: false suppresses the output.

1. `formatFix`: changed condition from `data.fixed && data.fixed_sql` to `data.fixed_sql && data.fixed !== false` so a valid `fixed_sql` is not silently discarded when `fixed` field is absent 2. `sql/register.ts`: wrapped all 10 composite SQL handlers in exportable `registerAllSql()` function (mirrors `registerAll()` pattern from `altimate-core.ts`) 3. All 3 e2e test files now call both `core.registerAll()` and `sql.registerAllSql()` in `beforeAll` to survive `Dispatcher.reset()` from other test files — fixes CI "No native handler" failures Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

claude bot reviewed Mar 18, 2026

View reviewed changes

github-actions bot added the contributor label Mar 18, 2026

sentry bot reviewed Mar 18, 2026

View reviewed changes

packages/opencode/src/altimate/native/schema-resolver.ts Show resolved Hide resolved

anandgupta42 and others added 2 commits March 18, 2026 08:48

sentry bot reviewed Mar 18, 2026

View reviewed changes

packages/opencode/src/altimate/tools/altimate-core-query-pii.ts Show resolved Hide resolved

anandgupta42 and others added 3 commits March 18, 2026 08:58

sentry bot reviewed Mar 18, 2026

View reviewed changes

anandgupta42 merged commit 8fd0c7b into main Mar 18, 2026
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: dbt tool regression — schema format mismatch, silent failures, wrong results#263

fix: dbt tool regression — schema format mismatch, silent failures, wrong results#263
anandgupta42 merged 7 commits intomainfrom
fix/dbt-tool-regression

anandgupta42 commented Mar 18, 2026

Uh oh!

claude bot left a comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

anandgupta42 Mar 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

anandgupta42 commented Mar 18, 2026

What does this PR do?

Type of change

Issue for this PR

How did you verify your code works?

Checklist

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

anandgupta42 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant