test: altimate tools — impact analysis DAG traversal and training import parsing

[anandgupta42]

What does this PR do?

Adds 20 new tests for two recently added tools (impact_analysis, training_import) from PR #350 that shipped with zero test coverage. Both tools are user-facing and handle complex input parsing where bugs could cause wrong decisions or silent data loss.

1. ImpactAnalysisTool — src/altimate/tools/impact-analysis.ts (10 new tests)

This tool analyzes downstream impact of dbt model/column changes across the DAG. Zero tests existed despite containing a recursive DAG traversal algorithm (findDownstream) and severity classification logic. New coverage includes:

• Empty/missing manifest handling (NO MANIFEST, MODEL NOT FOUND responses)
• Linear chain traversal — correctly identifies direct vs transitive dependents
• Diamond dependency deduplication — each model counted only once via visited set
• Dotted depends_on references (e.g. project.stg_orders → stg_orders)
• Severity classification boundaries (SAFE/LOW/MEDIUM/HIGH thresholds)
• Blast radius percentage calculation in formatted output
• Error handling when Dispatcher is unavailable
• Change type warnings (BREAKING for remove, CAUTION for retype, rename update guidance)

2. TrainingImportTool — src/altimate/tools/training-import.ts (10 new tests)

This tool imports training entries from markdown documents (style guides, glossaries). Zero tests existed despite a markdown parser (parseMarkdownSections) and capacity enforcement logic. New coverage includes:

• H2 section extraction as separate training entries
• H1 context prefix injection into section content
• No-sections-found error when markdown lacks H2 headings
• Empty section skipping (H2 with only whitespace)
• max_entries limit enforcement
• Capacity enforcement — warns and marks SKIP when near TRAINING_MAX_PATTERNS_PER_KIND
• Actual import path — verifies TrainingStore.save called for each entry
• Save failure handling — skipped count and FAIL markers in output
• Slugify edge cases — special characters, em-dashes, parentheses
• File-not-found error propagation (ENOENT)

Type of change

• New feature (non-breaking change which adds functionality)

Issue for this PR

N/A — proactive test coverage for tools added in #350

How did you verify your code works?

bun test test/altimate/impact-analysis.test.ts    # 10 pass, 32 expect() calls
bun test test/altimate/training-import.test.ts    # 10 pass, 30 expect() calls

Both test files use spyOn to mock Dispatcher.call, TrainingStore, TrainingPrompt, and fs.readFile — no external dependencies, no flakiness risk.

Checklist

• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

https://claude.ai/code/session_01H7d93hQP5qAwYhLgRdkqhV

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

[coderabbitai]

Warning

Rate limit exceeded

@anandgupta42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c13e99dd-2533-45fc-8e55-2eede65b1606

📥 Commits

Reviewing files that changed from the base of the PR and between 11a27fe and 4d8e6ec.

📒 Files selected for processing (2)

• packages/opencode/test/altimate/impact-analysis.test.ts
• packages/opencode/test/altimate/training-import.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/test-impact-training-20260322-session_01H7d93hQP5qAwYhLgRdkqhV

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}