Skip to content

fix: include nested node_modules in NODE_PATH for NAPI resolution#576

Merged
anandgupta42 merged 1 commit intomainfrom
fix/napi-node-path-resolution
Mar 29, 2026
Merged

fix: include nested node_modules in NODE_PATH for NAPI resolution#576
anandgupta42 merged 1 commit intomainfrom
fix/napi-node-path-resolution

Conversation

@anandgupta42
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes Verdaccio sanity CI failure where @altimateai/altimate-core NAPI binding can't be found after npm install -g. The module is installed nested at <global_root>/altimate-code/node_modules/ but NODE_PATH only searched the global root.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Issue for this PR

Closes #575

How did you verify your code works?

  • Verified shell script syntax with bash -n
  • Traced CI logs: npm root -g returns /home/testuser/.npm-global/lib/node_modules but @altimateai/altimate-core lives at .../altimate-code/node_modules/@altimateai/altimate-core
  • Fix adds both paths to NODE_PATH in all 3 locations (Phase 1, Phase 1 drivers, Phase 1b)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing tests pass locally with my changes

🤖 Generated with Claude Code

After `npm install -g`, `@altimateai/altimate-core` is installed as a
dependency of `altimate-code` and lives at
`<global_root>/altimate-code/node_modules/`, not at the global root.
NODE_PATH must include both paths to handle npm's hoisted and nested
layouts.

This fixes the sole remaining Verdaccio sanity CI failure (Phase 1 and
Phase 1b NAPI binding checks).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

Warning

Rate limit exceeded

@anandgupta42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 31 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 31 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 06d6e673-67a0-46cd-be12-8bca2c09b400

📥 Commits

Reviewing files that changed from the base of the PR and between ddd7a6f and 916fb6b.

📒 Files selected for processing (2)
  • test/sanity/phases/verify-install-extended.sh
  • test/sanity/phases/verify-install.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/napi-node-path-resolution

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@anandgupta42 anandgupta42 merged commit 2180ce0 into main Mar 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Verdaccio sanity NAPI binding resolution fails in CI

1 participant