Skip to content

feat(sql): cross-DB join key inference via prefix/suffix overlap #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahrizvi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(sql): cross-DB join key inference via prefix/suffix overlap #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11372d4
feat(sql): cross-DB join key inference via prefix/suffix overlap
Apr 28, 2026
d16a92f
test: bump altimate_core method count to 35 for detect_join_candidates
Apr 28, 2026
80758f5
fix(sql): address consensus-review issues on detect_join_candidates
Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/opencode/src/altimate/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export * from "./tools/altimate-core-column-lineage"
export * from "./tools/altimate-core-compare"
export * from "./tools/altimate-core-complete"
export * from "./tools/altimate-core-correct"
export * from "./tools/altimate-core-detect-join-candidates"
export * from "./tools/altimate-core-equivalence"
export * from "./tools/altimate-core-export-ddl"
export * from "./tools/altimate-core-extract-metadata"
Expand Down
6 changes: 4 additions & 2 deletions packages/opencode/src/altimate/native/connections/data-diff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,11 @@ export function warehouseTypeToDialect(warehouseType: string): string {
/**
* Quote a SQL identifier using the correct delimiter for the dialect.
* Used both for partition column/value quoting and for plain-table-name
* wrapping inside CTEs (via `resolveTableSources`).
* wrapping inside CTEs (via `resolveTableSources`). Exported so other
* native handlers (e.g. `detect-join-candidates`) reuse the same
* dialect-aware logic instead of hardcoding ANSI quoting.
*/
function quoteIdentForDialect(identifier: string, dialect: string): string {
export function quoteIdentForDialect(identifier: string, dialect: string): string {
switch (dialect) {
case "mysql":
case "mariadb":
Expand Down
Loading
Loading