Skip to content

fix: change pydantic extra fields from forbid to allow in manifest parsers#92

Merged
mdesmet merged 1 commit intomainfrom
fix/always_allow
Feb 27, 2026
Merged

fix: change pydantic extra fields from forbid to allow in manifest parsers#92
mdesmet merged 1 commit intomainfrom
fix/always_allow

Conversation

@mdesmet
Copy link
Collaborator

@mdesmet mdesmet commented Feb 27, 2026

Allow extra fields in all manifest parser models to prevent validation errors when dbt manifests contain fields not defined in the schema.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com


Important

Change extra field in ConfigDict from forbid to allow in manifest parser models to permit extra fields, preventing validation errors.

  • Behavior:
    • Change extra field in ConfigDict from forbid to allow in manifest parser models to allow extra fields.
    • Affects models like ManifestMetadata, FileHash, Hook, DependsOn, Docs, InjectedCTE, TestConfig, SnapshotConfig, SeedConfig, MacroDependsOn, Quoting, FreshnessMetadata, SourceFreshnessRuntimeError, Time, TimingInfo, ExternalPartition, SourceConfig, MacroArgument, Documentation, ExposureConfig, MetricFilter, MetricTime, MetricConfig, NodeConfig, ColumnInfo, SingularTestNode, HookNode, ModelNode, RPCNode, SqlNode, GenericTestNode, SnapshotNode, SeedNode, SourceFreshnessOutput, ExternalTable, Macro, Exposure, Metric, AnalysisNode, SourceDefinition in manifest_v1.py, manifest_v2.py, manifest_v3.py, manifest_v4.py, manifest_v5.py, manifest_v6.py, manifest_v7.py, manifest_v8.py, manifest_v9.py.
  • Files:
    • Changes in manifest_v1.py, manifest_v2.py, manifest_v3.py ... manifest_v9.py to allow extra fields in models.

This description was created by Ellipsis for 541dea0. You can customize this summary. It will automatically update as commits are pushed.

…rsers

Allow extra fields in all manifest parser models to prevent validation
errors when dbt manifests contain fields not defined in the schema.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 541dea0 in 33 seconds. Click for details.
  • Reviewed 5887 lines of code in 12 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_MLelOiUcyfkhdzL9

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@mdesmet mdesmet merged commit e7af919 into main Feb 27, 2026
31 checks passed
@mdesmet mdesmet deleted the fix/always_allow branch February 27, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants