Check multiplexed connection before usage #1102
Conversation
| state.connection = nullptr; | ||
| state.pool_entry = IConnectionPool::Entry(); | ||
| --active_connection_count; | ||
| if (current_connection == old_connection) |
There was a problem hiding this comment.
Is it Ok that we don't acquire cancel_mutex here?
There was a problem hiding this comment.
Yes, invalidateReplica is called under that mutex already, like in MultiplexedConnections::disconnect https://github.com/Altinity/ClickHouse/blob/antalya/src/Client/MultiplexedConnections.cpp#L239
|
@ianton-ru please provide a proper description WHY we need this change and/or reference to the bug that it fixes. Otherwise there is no way to perform a code review of proper quality |
Crush catched by @filimonov. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Check multiplexed connection before usage
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: