23.3.19 Pre-release PR for 23.3.19.33.altinitystable

.github/actionlint.yml

@@ -1,9 +1,11 @@
 self-hosted-runner:
   labels:
-    - builder
-    - func-tester
-    - func-tester-aarch64
-    - fuzzer-unit-tester
-    - stress-tester
-    - style-checker
-    - style-checker-aarch64
+    - altinity-on-demand
+    - altinity-in-fsn1
+    - altinity-in-ash
+    - altinity-image-arm-app-docker-ce
+    - altinity-image-x86-app-docker-ce
+    - altinity-type-cax41
+    - altinity-type-cpx41
+    - altinity-type-cpx51
+    - altinity-type-ccx53

.github/actions/docker_setup/action.yml

@@ -0,0 +1,38 @@
+name: Docker setup
+description: Setup docker
+inputs:
+  nested_job:
+    description: the fuse for unintended use inside of the reusable callable jobs
+    default: true
+    type: boolean
+  DOCKER_USERNAME:
+    description: username for the dockerhub login
+    required: true
+    type: string
+  DOCKER_PASSWORD:
+    description: password for the dockerhub login
+    required: true
+    type: string
+runs:
+  using: "composite"
+  steps:
+    - name: Docker IPv6 configuration
+      shell: bash
+      run: |
+        # make sure docker uses proper IPv6 config
+        sudo touch /etc/docker/daemon.json
+        sudo chown ubuntu:ubuntu /etc/docker/daemon.json
+        sudo cat <<EOT > /etc/docker/daemon.json
+        {
+          "ipv6": true,
+          "fixed-cidr-v6": "2001:3984:3989::/64"
+        }
+        EOT
+        sudo chown root:root /etc/docker/daemon.json
+        sudo systemctl restart docker
+        sudo systemctl status docker
+    - name: Docker login
+      shell: bash
+      run: |
+        docker login -u ${{ inputs.DOCKER_USERNAME }} -p ${{ inputs.DOCKER_PASSWORD }}
+        docker info

.github/docker-ipv6-setup.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+sudo touch /etc/docker/daemon.json
+sudo chown ubuntu:ubuntu /etc/docker/daemon.json
+sudo cat <<EOT > /etc/docker/daemon.json
+{
+    "ipv6": true,
+    "fixed-cidr-v6": "2001:3984:3989::/64"
+}
+EOT
+sudo chown root:root /etc/docker/daemon.json
+sudo systemctl restart docker

.github/retry.sh

@@ -0,0 +1,22 @@
+#!/bin/bash
+# Execute command until exitcode is 0 or
+# maximum number of retries is reached
+# Example:
+#    ./retry <retries> <delay> <command>
+retries=$1
+delay=$2
+command="${@:3}"
+exitcode=0
+try=0
+until [ "$try" -ge $retries ]
+do
+  echo "$command"
+  eval "$command"
+  exitcode=$?
+  if [ $exitcode -eq 0 ]; then
+    break
+  fi
+  try=$((try+1))
+  sleep $2
+done
+exit $exitcode

.github/workflows/README.md

@@ -0,0 +1,248 @@
+# 23.3 GitHub CI/CD Pipeline
+
+## Release Test Fails
+| Job | Test Name | Reason | Resolution | Report | Detail |  
+| --- | --------- | ------ | ---------- | ------ | ------ |   
+| FunctionalStatelessMsan3 | 00534_functions_bad_arguments5 | Timeout | Consistent fail | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/stateless_tests__msan__[4_6].html | |  
+| FunctionalStatelessMsan3 | 00534_functions_bad_arguments6 | Timeout | Consistent fail | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/stateless_tests__msan__[4_6].html | |  
+| FunctionalStatelessMsan3 | 00534_functions_bad_arguments9 | Timeout | Consistent fail | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/stateless_tests__msan__[4_6].html | |  
+| FunctionalStatelessMsan4 | 00534_functions_bad_arguments2 | Timeout | Consistent fail | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/stateless_tests__msan__[5_6].html | |  
+| FunctionalStatelessMsan4 | 00534_functions_bad_arguments7 | Timeout | Consistent fail | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/stateless_tests__msan__[5_6].html | |  
+| FunctionalStatelessS3Debug0 | 02479_mysql_connect_to_self | Fail to connect to MySQL server | Consistent fail | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/stateless_tests__debug__s3_storage__[1_6].html |  
+| FunctionalStatelessDebug1 | 02561_null_as_default_more_formats | Fail to write to fail | Flaky | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/stateless_tests__debug__[2_5].html | Passed on the previous run |  
+| FunctionalStatelessDebug1 | 02703_jit_external_aggregation | Timeout | Consistent fail | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/stateless_tests__debug__[2_5].html | |  
+| StressTestAsan | | | | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/stress_test__tsan_.html | |  
+| StressTestTsan | | | | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/stress_test__tsan_.html | |  
+| SQLancer (release) | ALL | settings used not supported on 23.3 | OK to fail | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/sqlancer__release_.html | |  
+| SQLancer (debug) | ALL | settings used not supported on 23.3 | OK to fail | https://s3.amazonaws.com/altinity-build-artifacts/315/40a1d584f651d64851fd801cb147abb3de03378d/sqlancer__debug_.html | |  
+
+
+## Comparison to ClickHouse
+Comparison between ClickHouse and Altinity CI/CD pipeline. Primary focus on the comparison is on testing and builds.  
+ClickHouse workflows from https://github.com/ClickHouse/ClickHouse/tree/ff5101070e4732977e72d810f0e0ca1042dd4d3a.  
+
+### Master only
+
+The following workflow files are included but they're only run on the master branch:
+- jepsen.yml
+- nightly.yml
+- master.yml
+- woboq.yml
+
+### Not included workflows
+
+The following workflow files are not included in the comparison as they are minor, not used, or do not provide any new tests relative to other workflows:
+- backport_branches.yml
+- cancel.yml
+- cherry_pick.yml
+- debug.yml
+- pull_request_approved.yml
+- release.yml
+- tags_stable.yml
+- docs_check.yml
+
+### pull_request.yml
+
+https://github.com/ClickHouse/ClickHouse/blob/23.3/.github/workflows/pull_request.yml
+
+| Job  | In altinity pipeline? |  
+| ------ | ------------ |  
+| CheckLabels | no, ClickHouse PR label management tool. | 
+| PythonUnitTests | no, ClickHouse infrastructure tests. | 
+| DockerHubPushAarch64 | yes | 
+| DockerHubPushAmd64 | yes | 
+| DockerHubPush | yes | 
+| StyleCheck | yes | 
+| FastTest | no, ClickHouse infrastructure tests. | 
+| CompatibilityCheckX86 | yes | 
+| CompatibilityCheckAarch64 | yes | 
+| BuilderDebRelease | yes | 
+| BuilderBinRelease | yes | 
+| BuilderDebAarch64 | yes | 
+| BuilderDebAsan | yes |
+| BuilderDebUBsan | yes | 
+| BuilderDebTsan | yes | 
+| BuilderDebMsan | yes |
+| BuilderDebDebug | yes | 
+| BuilderBinClangTidy | no, we are focused on deb. | 
+| BuilderBinDarwin | no, we are focused on deb. | 
+| BuilderBinAarch64 | no, we are focused on deb. | 
+| BuilderBinFreeBSD | no, we are focused on deb. | 
+| BuilderBinDarwinAarch64 | no, we are focused on deb. | 
+| BuilderBinPPC64| no, we are focused on deb. | 
+| BuilderBinAmd64Compat | no, we are focused on deb. | 
+| BuilderBinAarch64V80Compat | no, we are focused on deb. | 
+| DockerServerImages | yes | 
+| BuilderReport | yes | 
+| BuilderSpecialReport | no, depends on bin builder stages. | 
+| InstallPackagesTestRelease | yes | 
+| InstallPackagesTestAarch64 | yes | 
+| FunctionalStatelessTestRelease | yes | 
+| FunctionalStatelessTestReleaseDatabaseReplicated0 | yes | 
+| FunctionalStatelessTestReleaseDatabaseReplicated1 | yes | 
+| FunctionalStatelessTestReleaseDatabaseReplicated2 | yes | 
+| FunctionalStatelessTestReleaseDatabaseReplicated3 | yes | 
+| FunctionalStatelessTestReleaseWideParts | yes | 
+| FunctionalStatelessTestReleaseS3_0 | yes | 
+| FunctionalStatelessTestReleaseS3_1 | yes | 
+| FunctionalStatelessTestS3Debug0 | yes | 
+| FunctionalStatelessTestS3Debug1 | yes | 
+| FunctionalStatelessTestS3Debug2 | yes | 
+| FunctionalStatelessTestS3Debug3 | yes | 
+| FunctionalStatelessTestS3Debug4 | yes | 
+| FunctionalStatelessTestS3Debug5 | yes | 
+| FunctionalStatelessTestS3Tsan0 | yes | 
+| FunctionalStatelessTestS3Tsan1 | yes | 
+| FunctionalStatelessTestS3Tsan2 | yes | 
+| FunctionalStatelessTestS3Tsan3 | yes | 
+| FunctionalStatelessTestS3Tsan4 | yes | 
+| FunctionalStatelessTestAarch64 | yes | 
+| FunctionalStatelessTestAsan0 | yes | 
+| FunctionalStatelessTestAsan1 | yes | 
+| FunctionalStatelessTestAsan2 | yes | 
+| FunctionalStatelessTestAsan3 | yes | 
+| FunctionalStatelessTestTsan0 | yes | 
+| FunctionalStatelessTestTsan1 | yes | 
+| FunctionalStatelessTestTsan2 | yes | 
+| FunctionalStatelessTestTsan3 | yes | 
+| FunctionalStatelessTestTsan4 | yes | 
+| FunctionalStatelessTestUBsan0 | yes | 
+| FunctionalStatelessTestUBsan1 | yes | 
+| FunctionalStatelessTestMsan0 | yes | 
+| FunctionalStatelessTestMsan1 | yes | 
+| FunctionalStatelessTestMsan2 | yes | 
+| FunctionalStatelessTestMsan3 | yes | 
+| FunctionalStatelessTestMsan4 | yes | 
+| FunctionalStatelessTestMsan5 | yes | 
+| FunctionalStatelessTestDebug0 | yes | 
+| FunctionalStatelessTestDebug1 | yes | 
+| FunctionalStatelessTestDebug2 | yes | 
+| FunctionalStatelessTestDebug3 | yes | 
+| FunctionalStatelessTestDebug4 | yes | 
+| FunctionalStatelessTestFlakyCheck | yes | 
+| TestsBugfixCheck | no, depends on CheckLabels | 
+| FunctionalStatefulTestRelease | yes | 
+| FunctionalStatefulTestAarch64 | yes | 
+| FunctionalStatefulTestAsan | yes | 
+| FunctionalStatefulTestTsan | yes | 
+| FunctionalStatefulTestMsan | yes | 
+| FunctionalStatefulTestUBsan | yes | 
+| FunctionalStatefulTestDebug | yes | 
+| FunctionalStatefulTestDebugParallelReplicas | yes | 
+| FunctionalStatefulTestUBsanParallelReplicas | yes | 
+| FunctionalStatefulTestMsanParallelReplicas | yes | 
+| FunctionalStatefulTestTsanParallelReplicas | yes | 
+| FunctionalStatefulTestAsanParallelReplicas | yes | 
+| FunctionalStatefulTestReleaseParallelReplicas | yes | 
+| StressTestAsan | yes | 
+| StressTestTsan | yes | 
+| StressTestMsan | yes | 
+| StressTestUBsan | yes | 
+| StressTestDebug | yes | 
+| UpgradeCheckAsan | no, in development. | 
+| UpgradeCheckTsan | no, in development. | 
+| UpgradeCheckMsan | no, in development. | 
+| UpgradeCheckDebug | no, in development. | 
+| ASTFuzzerTestAsan | yes | 
+| ASTFuzzerTestTsan | yes | 
+| ASTFuzzerTestUBSan | yes | 
+| ASTFuzzerTestMSan | yes | 
+| ASTFuzzerTestDebug | yes | 
+| IntegrationTestsAsan0 | yes | 
+| IntegrationTestsAsan1 | yes | 
+| IntegrationTestsAsan2 | yes | 
+| IntegrationTestsAsan3 | yes | 
+| IntegrationTestsAsan4 | yes | 
+| IntegrationTestsAsan5 | yes | 
+| IntegrationTestsTsan0 | yes | 
+| IntegrationTestsTsan1 | yes | 
+| IntegrationTestsTsan2 | yes | 
+| IntegrationTestsTsan3 | yes | 
+| IntegrationTestsTsan4 | yes | 
+| IntegrationTestsTsan5 | yes | 
+| IntegrationTestsRelease0 | yes | 
+| IntegrationTestsRelease1 | yes | 
+| IntegrationTestsRelease2 | yes | 
+| IntegrationTestsRelease3 | yes | 
+| IntegrationTestsFlakyCheck | yes | 
+| UnitTestsAsan | yes | 
+| UnitTestsReleaseClang | yes | 
+| UnitTestsTsan | yes | 
+| UnitTestsMsan | yes | 
+| UnitTestsUBsan | yes | 
+| PerformanceComparisonX86-0 | no, to be added. | 
+| PerformanceComparisonX86-1 | no, to be added. | 
+| PerformanceComparisonX86-2 | no, to be added. | 
+| PerformanceComparisonX86-3 | no, to be added. | 
+| PerformanceComparisonAarch-0 | no, to be added. | 
+| PerformanceComparisonAarch-1 | no, to be added. | 
+| PerformanceComparisonAarch-2 | no, to be added. | 
+| PerformanceComparisonAarch-3 | no, to be added. | 
+| SQLancerTestRelease | yes | 
+| SQLancerTestDebug | yes | 
+| Jepsen | no, in development. | 
+
+Jepsen job only runs if the pull request name containes `jepsen-test`
+
+### release_branches.yml  
+
+https://github.com/ClickHouse/ClickHouse/blob/23.3/.github/workflows/release_branches.yml
+
+| Job  | In altinity pipeline? |  
+| ------ | ------------ |  
+| DockerHubPushAarch64 | yes |
+| DockerHubPushAmd64 | yes |
+| DockerHubPush | yes | 
+| CompatibilityCheckX86 | yes | 
+| CompatibilityCheckAarch64 | yes | 
+| BuilderDebRelease | yes | 
+| BuilderDebAarch64 | yes | 
+| BuilderDebAsan | yes |
+| BuilderDebUBsan | yes | 
+| BuilderDebTsan | yes | 
+| BuilderDebMsan | yes |
+| BuilderDebDebug | yes | 
+| BuilderBinDarwin | no, we are only focused on deb. | 
+| BuilderBinDarwinAarch64 | no, we are only focused on deb. | 
+| DockerServerImages | yes | 
+| BuilderReport | yes | 
+| BuilderSpecialReport | no, depends on bin builder stages. | 
+| MarkReleaseReady | yes | 
+| InstallPackagesTestRelease | yes | 
+| InstallPackagesTestAarch64 | yes | 
+| FunctionalStatelessTestRelease | yes | 
+| FunctionalStatelessTestAarch64 | yes | 
+| FunctionalStatelessTestAsan0 | yes | 
+| FunctionalStatelessTestAsan1 | yes | 
+| FunctionalStatelessTestTsan0 | yes | 
+| FunctionalStatelessTestTsan1 | yes | 
+| FunctionalStatelessTestTsan2 | yes | 
+| FunctionalStatelessTestUBsan | yes | 
+| FunctionalStatelessTestMsan0 | yes | 
+| FunctionalStatelessTestMsan1 | yes | 
+| FunctionalStatelessTestMsan2 | yes | 
+| FunctionalStatelessTestDebug0 | yes | 
+| FunctionalStatelessTestDebug1 | yes | 
+| FunctionalStatelessTestDebug2 | yes | 
+| FunctionalStatefulTestRelease | yes | 
+| FunctionalStatefulTestAarch64 | yes | 
+| FunctionalStatefulTestAsan | yes | 
+| FunctionalStatefulTestTsan | yes | 
+| FunctionalStatefulTestMsan | yes | 
+| FunctionalStatefulTestUBsan | yes | 
+| FunctionalStatefulTestDebug | yes |
+| StressTestAsan | yes | 
+| StressTestTsan | yes | 
+| StressTestMsan | yes | 
+| StressTestUBsan | yes | 
+| StressTestDebug | yes | 
+| IntegrationTestsAsan0 | yes | 
+| IntegrationTestsAsan1 | yes | 
+| IntegrationTestsAsan2 | yes | 
+| IntegrationTestsTsan0 | yes | 
+| IntegrationTestsTsan1 | yes | 
+| IntegrationTestsTsan2 | yes | 
+| IntegrationTestsTsan3 | yes | 
+| IntegrationTestsRelease0 | yes | 
+| IntegrationTestsRelease1 | yes | 
+| FinishCheck | yes | 

.github/workflows/backport_branches.yml

@@ -176,13 +176,13 @@ jobs:
           clear-repository: true
           fetch-depth: 0  # It MUST BE THE SAME for all dependencies and the job itself
           filter: tree:0
-      - name: Check docker clickhouse/clickhouse-server building
+      - name: Check docker altinityinfra/clickhouse-server building
         run: |
           cd "$GITHUB_WORKSPACE/tests/ci"
           python3 docker_server.py --release-type head --no-push \
-            --image-repo clickhouse/clickhouse-server --image-path docker/server
+            --image-repo altinityinfra/clickhouse-server --image-path docker/server
           python3 docker_server.py --release-type head --no-push \
-            --image-repo clickhouse/clickhouse-keeper --image-path docker/keeper
+            --image-repo altinityinfra/clickhouse-keeper --image-path docker/keeper
       - name: Cleanup
         if: always()
         run: |